Skip to content

Fixes #532 #536

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 21, 2016
Merged

Fixes #532 #536

merged 2 commits into from
Oct 21, 2016

Conversation

juoceano
Copy link
Contributor

Since this happened due to the leaflet update I think I should fix it 😬

onclick="{{this._parent.get_name()}}.toggleScroll()"></img>
<img id="{{this.get_name()}}" alt="scroll"
src="https://cdnjs.cloudflare.com/ajax/libs/ionicons/2.0.1/png/512/arrow-move.png"
style="z-index: 999999"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hackish but unless we add as an icon, use css to inherit the z-index I do not see another solution... Merging this for now.

src="https://cdnjs.cloudflare.com/ajax/libs/ionicons/1.5.2/png/512/arrow-move.png"
onclick="{{this._parent.get_name()}}.toggleScroll()"></img>
<img id="{{this.get_name()}}" alt="scroll"
src="https://cdnjs.cloudflare.com/ajax/libs/ionicons/2.0.1/png/512/arrow-move.png"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ocefpaf ocefpaf merged commit 3d3d26a into python-visualization:master Oct 21, 2016
@juoceano juoceano deleted the fix_532 branch October 21, 2016 21:10
sanga pushed a commit to sanga/folium that referenced this pull request Oct 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants