Added weight option to CircleMarker #581
Conversation
|
Looks good! Thanks!! I guess you will need to update the test to incorporate the new |
|
Yes. Sorry for the testing oversight. I am still getting the hang of this system. I will have a fix up shortly. |
No problem. It is the holidays and I finally have some time for |
|
The tests are now passing. Thank you for your patience. |
| @@ -753,6 +753,8 @@ class CircleMarker(Marker): | |||
| use Circle. | |||
| color: str, default 'black' | |||
| The color of the marker's edge in a HTML-compatible format. | |||
| weight: int, default 2 | |||
There was a problem hiding this comment.
Leaflet docs are hard to follow sometimes. It says that CircleMarker extends Circle that extends Path which has a weight default of 5. What is the reason that lead you to choose 2 instead? (Just curios, you don't need to change to 5. Images maybe help us decided here 😄 )
|
The only reason I picked it was because I saw it as the default on another
class that already had the option. I'm fine with 5 if that fits better.
…On Sat, Dec 31, 2016, 12:22 PM Filipe ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In folium/features.py
<#581 (review)>
:
> @@ -753,6 +753,8 @@ class CircleMarker(Marker):
use Circle.
color: str, default 'black'
The color of the marker's edge in a HTML-compatible format.
+ weight: int, default 2
Leaflet docs are hard to follow sometimes. It says that CircleMarker
extends Circle that extends Path which has a weight default of 5. What is
the reason that lead you to choose 2 instead? (Just curios, you don't
need to change to 5. Images maybe help us decided here 😄 )
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#581 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAAnCTCxaE0V8uOd5OuxOcI3oRF0SW5Zks5rNrlogaJpZM4LYm6L>
.
|
To be honest I never plotted the difference 😬 Let's merge with Thanks @palewire for the awesome addition! |
…a-coalition/weight-circle-marker Added weight option to CircleMarker
No description provided.