Fix wms layer py3k #59
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
|
@birdage I really want to avoid self merges. Can you take a quick look at this PR and hit the green button? As soon as this PR is merged we can close #36, send a new release to PyPI and fix our conda packages and make @rsignell-usgs happy! |
|
+1 on making @rsignell-usgs happy! |
|
@ocefpaf looks good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a minor python 3 bug in
add_wms_layer. It also implements a test for that feature to prevent this bug from re-surfacing.(In addition I pep8'ed
folium_tests.py.)@birdage Can you review and merge this tiny PR?