Replace seawater with geographiclib. #605
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It is only used to build one of the examples. So you need to update the example too. |
|
It is already updated. Also, fixed a warning from ipykernel. |
|
Missed that. But we don't have your alternative packaged. Could you try
https://github.com/axiom-data-science/pygc instead?
|
There's no real use of the seawater package for anything seawater-related, but instead it's used for calculating azimuths. GeographicLib can do this much more accurately (though it's not really a huge difference.)
QuLogic
force-pushed
the
remove-seawater
branch
from
c34f6e9 to
9976924
Compare
|
Thanks @QuLogic. Sorry for the delay to merge this. |
sanga
pushed a commit
to sanga/folium
that referenced
this pull request
Oct 24, 2017
Replace seawater with geographiclib.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's no real use of the seawater package for anything seawater-related, but instead it's used for calculating azimuths. GeographicLib can do this much more accurately (though it's not really a huge difference.)
Plus, its tests are rather heavy and I'm a bit wary of the license (cf. pyoceans/python-seawater#16).
This won't pass without conda-forge/staged-recipes#2586 though.