Add subdomains option for TileLayer #623
Conversation
|
I am 👍 to that change. Can you update the test template to reflect the extra line: We need a changelog entry for that. Bonus if you add a notebook to our gallery with a few use cases 😄 |
tests/test_folium.py
Outdated
|
|
||
| url_with_name = 'http://{s}.custom_tiles-subdomains.org/{z}/{x}/{y}.png' | ||
| tile_layer = folium.map.TileLayer(url, name='subdomains2', | ||
| attr='attribution', |
There was a problem hiding this comment.
E127 continuation line over-indented for visual indent
tests/test_folium.py
Outdated
| url_with_name = 'http://{s}.custom_tiles-subdomains.org/{z}/{x}/{y}.png' | ||
| tile_layer = folium.map.TileLayer(url, name='subdomains2', | ||
| attr='attribution', | ||
| subdomains='5678') |
There was a problem hiding this comment.
E127 continuation line over-indented for visual indent
|
Do you agree this should bump the minor version? |
Makes sense. Don't forget to add a changelog entry. |
Some tile services use a diferent set of subdomains.
|
Is there anything else that needs to be done in order to get this merged? |
Nope. I've just been awfully busy with the day job. Thanks for the PR! |
Add subdomains option for TileLayer
Some tile services use a different set of subdomains. For reference: http://leafletjs.com/reference-1.0.3.html#tilelayer-subdomains