PNG repr #634

ocefpaf · 2017-06-24T02:24:42Z

Not ready yet... just an idea for now.

See http://nbviewer.jupyter.org/gist/ocefpaf/f5a5cbdefac17985db0d89d82455e3ff

This could be used to save a png, pdf, etc.

xref.: #35

ocefpaf · 2017-06-24T02:30:21Z

folium/map.py

@@ -246,6 +249,26 @@ def _repr_html_(self, **kwargs):
            out = self._parent._repr_html_(**kwargs)
        return out

+    def _repr_png_(self):
+        """Displays the PNG Map in a Jupyter notebook."""
+        # https://github.com/ipython/ipython/issues/7899#issuecomment-76541102


The notebook will run all _repr_*_ methods and, b/c this one can be slow, we don't really want it to be called without the user request. Not sure yet if this should be a _repr_png_ of just a to_png() method.

ocefpaf · 2017-06-24T02:41:16Z

folium/map.py

+                driver.maximize_window()
+                # Ignore user map size.
+                driver.execute_script("document.body.style.width = '100%';")
+                png = driver.get_screenshot_as_png()


We probably want to "sleep" here for a few seconds to allow for the tiles to render.
Maybe that should be a kwargs.

ocefpaf · 2017-06-24T02:47:32Z

folium/map.py

+            with tempfile.NamedTemporaryFile(suffix=".html") as f:
+                fname = f.name
+                self.save(fname)
+                driver = selenium.webdriver.PhantomJS(service_log_path=os.path.devnull)


Should probably add a try/except clause here to test for PhantomJS.

Actually the default error message from selenium is quite good. No need to override it.

PNG repr

astrojuanlu · 2018-01-26T12:38:09Z

Now a deprecation warning appears: UserWarning: Selenium support for PhantomJS has been deprecated, please use headless versions of Chrome or Firefox instead.

https://github.com/SeleniumHQ/selenium/blob/c5e4a585f1e3c4b3468ec93ab50d3668d47aef1b/py/CHANGES#L8

So this is likely to break soon.

ocefpaf · 2018-01-26T12:42:10Z

Thanks for the heads up!

I'm already trying to fix this for the branca tests but I'm not sure yet on a good pattern for folium b/c we need to catch whatever the user has installed or force the user to always pass a driver, to be honest I don't like any of those solutions 😒

nderen · 2018-09-28T21:44:11Z

Hi,

I've been trying to use this for a project, and while it works locally, if I build my application into a docker image or try to run it from a Google Cloud Compute instance, it fails. It looks like it's trying to contact one of the dependent services (there are a number of script, css, etc embeds in the the generated HTML) but one of those fails to return any data. Unfortunately, the exceptions provided do not indicate which. Tracebacks (with some of the paths salted) below.

Traceback (most recent call last):
  File "/home/<###>/.local/lib/python3.5/site-packages/urllib3/connectionpool.py", line 601, in urlopen
    chunked=chunked)
  File "/home/<###>/.local/lib/python3.5/site-packages/urllib3/connectionpool.py", line 387, in _make_request
    six.raise_from(e, None)
  File "<string>", line 2, in raise_from
  File "/home/<###>/.local/lib/python3.5/site-packages/urllib3/connectionpool.py", line 383, in _make_request
    httplib_response = conn.getresponse()
  File "/usr/lib/python3.5/http/client.py", line 1198, in getresponse
    response.begin()
  File "/usr/lib/python3.5/http/client.py", line 297, in begin
    version, status, reason = self._read_status()
  File "/usr/lib/python3.5/http/client.py", line 266, in _read_status
    raise RemoteDisconnected("Remote end closed connection without"
http.client.RemoteDisconnected: Remote end closed connection without response

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/opt/<###>/app.py", line 68, in <module>
    generate_map(token)
  File "/opt/<###>/app.py", line 44, in generate_map
    png = m._to_png(delay=60)
  File "/home/<###>/.local/lib/python3.5/site-packages/folium/folium.py", line 313, in _to_png
    driver.execute_script('document.write(\"{}\")'.format(html))
  File "/home/<###>/.local/lib/python3.5/site-packages/selenium/webdriver/remote/webdriver.py", line 635, in execute_script
    'args': converted_args})['value']
  File "/home/<###>/.local/lib/python3.5/site-packages/selenium/webdriver/remote/webdriver.py", line 318, in execute
    response = self.command_executor.execute(driver_command, params)
  File "/home/<###>/.local/lib/python3.5/site-packages/selenium/webdriver/remote/remote_connection.py", line 375, in execute
    return self._request(command_info[0], url, body=data)
  File "/home/<###>/.local/lib/python3.5/site-packages/selenium/webdriver/remote/remote_connection.py", line 402, in _request
    resp = http.request(method, url, body=body, headers=headers)
  File "/home/<###>/.local/lib/python3.5/site-packages/urllib3/request.py", line 70, in request
    **urlopen_kw)
  File "/home/<###>/.local/lib/python3.5/site-packages/urllib3/request.py", line 148, in request_encode_body
    return self.urlopen(method, url, **extra_kw)
  File "/home/<###>/.local/lib/python3.5/site-packages/urllib3/poolmanager.py", line 321, in urlopen
    response = conn.urlopen(method, u.request_uri, **kw)
  File "/home/<###>/.local/lib/python3.5/site-packages/urllib3/connectionpool.py", line 639, in urlopen
    _stacktrace=sys.exc_info()[2])
  File "/home/<###>/.local/lib/python3.5/site-packages/urllib3/util/retry.py", line 357, in increment
    raise six.reraise(type(error), error, _stacktrace)
  File "/home/<###>/.local/lib/python3.5/site-packages/urllib3/packages/six.py", line 685, in reraise
    raise value.with_traceback(tb)
  File "/home/<###>/.local/lib/python3.5/site-packages/urllib3/connectionpool.py", line 601, in urlopen
    chunked=chunked)
  File "/home/<###>/.local/lib/python3.5/site-packages/urllib3/connectionpool.py", line 387, in _make_request
    six.raise_from(e, None)
  File "<string>", line 2, in raise_from
  File "/home/<###>/.local/lib/python3.5/site-packages/urllib3/connectionpool.py", line 383, in _make_request
    httplib_response = conn.getresponse()
  File "/usr/lib/python3.5/http/client.py", line 1198, in getresponse
    response.begin()
  File "/usr/lib/python3.5/http/client.py", line 297, in begin
    version, status, reason = self._read_status()
  File "/usr/lib/python3.5/http/client.py", line 266, in _read_status
    raise RemoteDisconnected("Remote end closed connection without"
urllib3.exceptions.ProtocolError: ('Connection aborted.', RemoteDisconnected('Remote end closed connection without response',))

Conengmo · 2018-09-29T06:59:44Z

@nderen please don't post this in an old PR, open a new issue for it. You can link to this PR if needed.

ocefpaf force-pushed the png_repr branch from 5ae7d2f to 7efaf71 Compare June 24, 2017 02:26

PNG repr

e4ea523

ocefpaf force-pushed the png_repr branch from 7efaf71 to e4ea523 Compare June 24, 2017 02:28

ocefpaf commented Jun 24, 2017

View reviewed changes

python-visualization deleted a comment from stickler-ci Jun 24, 2017

ocefpaf added 4 commits June 24, 2017 15:17

PNG repr tests

70986ce

do not render png on notebooks by default

0930054

show png too

b80b9fd

use phantomjs from conda-forge

cf0395a

ocefpaf merged commit bb46954 into python-visualization:master Jun 24, 2017

ocefpaf deleted the png_repr branch June 24, 2017 20:39

ocefpaf mentioned this pull request Jun 24, 2017

Save image #35

Closed

sanga pushed a commit to sanga/folium that referenced this pull request Oct 24, 2017

Merge pull request python-visualization#634 from ocefpaf/png_repr

e0072c5

PNG repr

mihalw28 mentioned this pull request Jun 11, 2018

PermissionError: [Errno 13] Permission denied: 'C:\\Users\\%blah\\AppData\\Local\\Temp\\tmpaqaf567o.html' vincentropy/python_cartography_tutorial#1

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

PNG repr #634

PNG repr #634

Uh oh!

ocefpaf commented Jun 24, 2017

Uh oh!

ocefpaf Jun 24, 2017

Uh oh!

ocefpaf Jun 24, 2017

Uh oh!

ocefpaf Jun 24, 2017

Uh oh!

ocefpaf Jun 24, 2017

Uh oh!

astrojuanlu commented Jan 26, 2018

Uh oh!

ocefpaf commented Jan 26, 2018

Uh oh!

nderen commented Sep 28, 2018 •

edited

Loading

Uh oh!

Conengmo commented Sep 29, 2018 •

edited

Loading

Uh oh!

Uh oh!

PNG repr #634

PNG repr #634

Uh oh!

Conversation

ocefpaf commented Jun 24, 2017

Uh oh!

ocefpaf Jun 24, 2017

Choose a reason for hiding this comment

Uh oh!

ocefpaf Jun 24, 2017

Choose a reason for hiding this comment

Uh oh!

ocefpaf Jun 24, 2017

Choose a reason for hiding this comment

Uh oh!

ocefpaf Jun 24, 2017

Choose a reason for hiding this comment

Uh oh!

astrojuanlu commented Jan 26, 2018

Uh oh!

ocefpaf commented Jan 26, 2018

Uh oh!

nderen commented Sep 28, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Conengmo commented Sep 29, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

nderen commented Sep 28, 2018 •

edited

Loading

Conengmo commented Sep 29, 2018 •

edited

Loading