Vega-Lite features #643
Merged
Vega-Lite features #643
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
largely based on the existing Vega element, VegaLite can take a vega-lite string or an Altair chart object to embed visualizations this uses the older, more stable vega-lite 1.x API
stickler-ci
reviewed
Jul 12, 2017
| name='vega') | ||
|
|
||
| figure.header.add_child( | ||
| JavascriptLink('https://cdnjs.cloudflare.com/ajax/libs/vega-lite/1.3.1/vega-lite.min.js'), |
There was a problem hiding this comment.
E501 line too long (102 > 100 characters)
stickler-ci
reviewed
Jul 12, 2017
| name='vega-lite') | ||
|
|
||
| figure.header.add_child( | ||
| JavascriptLink('https://cdnjs.cloudflare.com/ajax/libs/vega-embed/2.2.0/vega-embed.min.js'), |
There was a problem hiding this comment.
E501 line too long (104 > 100 characters)
change `format` to `fmt` in example and docstring
needed for VegaLite example
|
@njwilson23 this is awesome! I'm attending a conference at the moment but I promise a careful review as soon as possible. (This must be in the next release!) |
|
@njwilson23 sorry for the delay in merging this and thanks for the PR! I am inclined to remove the |
|
@ocefpaf Ah no worries - everyone gets busy. |
Closed
sanga
pushed a commit
to sanga/folium
that referenced
this pull request
Oct 24, 2017
Vega-Lite features
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've implemented a
VegaLiteelement (cf. #488), and added a couple of examples reproducing the Vega versions.This uses v1 of Vega-Lite, although it looks like v2 may be available soon.
I couldn't figure out how the Vega code was tested - if you could point me to the right place to look, I can try to create matching tests for the Vega-Lite.