Skip to content

Implement measure plugin closes #472 #669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 23, 2017

Conversation

ocefpaf
Copy link
Member

@ocefpaf ocefpaf commented Aug 23, 2017

@BibMartin I went for https://github.com/ljagis/leaflet-measure instead of https://github.com/jtreml/leaflet.measure

ljagis/leaflet-measure seems more up to date, works fine with latest leaflet, and has more functionalities.

@ocefpaf ocefpaf mentioned this pull request Aug 23, 2017
@ocefpaf ocefpaf merged commit be35c52 into python-visualization:master Aug 23, 2017
@ocefpaf ocefpaf deleted the measure_distance branch August 23, 2017 21:16
@ocefpaf ocefpaf mentioned this pull request Aug 24, 2017
@BibMartin
Copy link
Contributor

Too late to help @ocefpaf ; sorry.
Good new feature though !

@ocefpaf
Copy link
Member Author

ocefpaf commented Aug 24, 2017

Too late to help @ocefpaf ; sorry.

Sorry. I assumed you were busy with day job and did not ping you.
But it is never too late 😉
Let me know if you have any review actions and I'll prepare another PR immediately.

Good new feature though !

Indeed. I would like to a hook to save the GeoJson afterwards. They have an example to print the points on the screen, but not to add a "save" button.

@BibMartin
Copy link
Contributor

Sorry. I assumed you were busy with day job and did not ping you.
But it is never too late 😉

Day job is pulling quite much therefore I cannot be as involved as I used to be ; but I'll try to answer when you ping me.

@ocefpaf
Copy link
Member Author

ocefpaf commented Aug 24, 2017

Day job is pulling quite much therefore I cannot be as involved as I used to be ;

I understand. I can only work on folium when it overlaps with the day job interests 😒

but I'll try to answer when you ping me.

Thanks! Next time I'll wait a few days before self-merging 😄

sanga pushed a commit to sanga/folium that referenced this pull request Oct 24, 2017
@cristi-neagu
Copy link

cristi-neagu commented Mar 15, 2021

Silly question, but how is this supposed to work? Can anyone please provide a short code snippet?

Well, spent about 15 minutes trying to figure this out with no success. And of course i find the solution a minute after asking here. Turns out there's an examples folder with an example for this in it. examples/plugin-MeasureControl.ipynb

@BibMartin
Copy link
Contributor

https://nbviewer.jupyter.org/github/python-visualization/folium/blob/master/examples/plugin-MeasureControl.ipynb

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants