Skip to content

Use pixelated image rendering for image overlays #684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 26, 2017
Merged

Use pixelated image rendering for image overlays #684

merged 3 commits into from
Aug 26, 2017

Conversation

dirkvdb
Copy link
Contributor

@dirkvdb dirkvdb commented Aug 26, 2017

As discusses previously. This changes the default css image-rendering style for image overlays to pixelated.

Tested on firefox and chrome

@ocefpaf
Copy link
Member

ocefpaf commented Aug 26, 2017

I'll fix the test template in another PR. Thanks @dirkvdb!

@ocefpaf ocefpaf merged commit 8216a86 into python-visualization:master Aug 26, 2017
@dirkvdb
Copy link
Contributor Author

dirkvdb commented Aug 26, 2017

Great, do you have a rough estimate on when 0.4.0 will be released?

@ocefpaf
Copy link
Member

ocefpaf commented Aug 26, 2017

I really want to get it out this weekend... But no promises.

@ocefpaf
Copy link
Member

ocefpaf commented Aug 26, 2017

BTW @dirkvdb do you have a before/after example to illustrate this change? It would be nice to add something to the gallery.

@dirkvdb
Copy link
Contributor Author

dirkvdb commented Aug 26, 2017

default

pixelated

See the attached files

@ocefpaf
Copy link
Member

ocefpaf commented Aug 26, 2017

Ah. Now I see what is expected 😄
I am not sure this PR does that 😕
I guess that the #{{this.get_name()}} . prevents it from being applied to .leaflet-image-layer.

Anyways, I have a PR ready here with another proof of concept. I'll ping you there to pick your brain.

ocefpaf added a commit to ocefpaf/folium that referenced this pull request Aug 26, 2017
ocefpaf added a commit that referenced this pull request Aug 26, 2017
sanga pushed a commit to sanga/folium that referenced this pull request Oct 24, 2017
…n#684)

* Use pixelated image rendering for image overlays

* Update CHANGES.txt

* Fixed typo in changes.txt
sanga pushed a commit to sanga/folium that referenced this pull request Oct 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants