Refactor Rectangle and Polygon #723
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stickler-ci
reviewed
Sep 16, 2017
tests/test_folium.py
Outdated
| @@ -14,7 +14,7 @@ | |||
| import branca.element | |||
|
|
|||
| import folium | |||
| from folium.features import PolygonMarker, RectangleMarker, TopoJson | |||
| from folium.features import Polygon, Rectangle, TopoJson | |||
There was a problem hiding this comment.
F401 'folium.features.Polygon' imported but unused
F401 'folium.features.Rectangle' imported but unused
stickler-ci
reviewed
Sep 16, 2017
tests/test_vector_layers.py
Outdated
| from folium.features import Circle, CircleMarker, Polygon, Rectangle | ||
| from folium.utilities import get_bounds | ||
|
|
||
| def test_circle(): |
There was a problem hiding this comment.
E302 expected 2 blank lines, found 1
sanga
pushed a commit
to sanga/folium
that referenced
this pull request
Oct 24, 2017
Refactor Rectangle and Polygon
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR:
tooltipsupport to all vector layersRectangleandPolygonand set to leaflet'sPathdefaults.get_boundsroutine to avoid wrong responsesPathoptionfill_coloris present it will overridefill=False