Explicit WMSTileLayer options, accept all **kwargs #838
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 28, 2018 09:47
The options for WMSTileLayer were parsed in a function in another module. To make it more explicit and simple I moved this to the class init, just like in the other classes. Also all **kwargs are now added to the options. This enables users to provide any Leaflet options such as minZoom.
This was referenced Mar 29, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #823.
The options for WMSTileLayer were parsed in a function in another module. To make it more explicit and simple I moved this to the class init, just like in the other classes.
Also all **kwargs are now added to the options. This enables users to provide any Leaflet options such as minZoom.
I didn't add the TileLayer arguments to WMSTileLayer, or make WMSTileLayer a subclass TileLayer. I'm in doubt if that added complexity would make things easier. I guess not.