Skip to content

Change default date_options to 24 hour clock in TimestampedGeoJson #914

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

andy23512
Copy link
Contributor

According to the document of moment.js https://momentjs.com/docs/#/displaying/format/ , hh shows hours in 01 to 12, while HH shows hours in 00 to 23.
The original code use hh to display hour, and it causes the time 14:00 shown as 02:00. It's a pretty weird and misleading default option.
I think displaying 24-hour clock with HH is a better choice.
Any suggestion or anything else I need to do?

@Conengmo
Copy link
Member

That makes sense, we can merge this. Two things:

  • Please add a line to the changelog.
  • While you're at it, maybe also change the date format to YYYY-MM-DD? That makes it even more ISO8601 compatible.

@andy23512
Copy link
Contributor Author

Thanks for the suggestions.
The date format has been refined, and the change information has been added in changelog.

@Conengmo Conengmo merged commit 41e494d into python-visualization:master Jul 19, 2018
@Conengmo
Copy link
Member

Merged! Thanks for the PR @andy23512.

@andy23512 andy23512 deleted the change-default-date-options-to-24-hour-clock-in-TimestampedGeoJson branch July 19, 2018 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants