Change default date_options to 24 hour clock in TimestampedGeoJson #914
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the document of moment.js https://momentjs.com/docs/#/displaying/format/ ,
hh
shows hours in 01 to 12, whileHH
shows hours in 00 to 23.The original code use
hh
to display hour, and it causes the time14:00
shown as02:00
. It's a pretty weird and misleading default option.I think displaying 24-hour clock with
HH
is a better choice.Any suggestion or anything else I need to do?