Added gradient to HeatMapWithTime. #925
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stickler-ci
reviewed
Aug 1, 2018
| }) | ||
| .addTo({{this._parent.get_name()}}); | ||
| var times = {{this.times}}; | ||
|
|
There was a problem hiding this comment.
W293 blank line contains whitespace
| {{this._parent.get_name()}}.timeDimension = L.timeDimension( | ||
| {times : times, currentTime: new Date(1)} | ||
| ); | ||
|
|
There was a problem hiding this comment.
W293 blank line contains whitespace
| timeSteps: {{this.index_steps}} | ||
| }) | ||
| .addTo({{this._parent.get_name()}}); | ||
|
|
There was a problem hiding this comment.
W293 blank line contains whitespace
|
Looks good to me! I was curious what color formats were accepted, so after looking into that I added that info to the docstring. Also did some minor cosmetic changes, and updated the test for this module. I made a crude fix for the failing Travis build in PR #926. After merging that we can update this PR from master and the test should pass after that. Then it's ready to merge IMO. |
|
Merged. Thanks @jtbaker! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #804, gradient arg is now added to HeatMapWithTime.