Update TimeDimension.Control css-link on TimestampedGeoJson plugin #963
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Our tests are failing because of some dependency BS. GeoPandas needs Fiona, which needs Boto3 which isn't in its requirements.
@ocefpaf you seem quite involved with conda-forge right, can you help? |
I actually caused that error 😳
Done. |
Haha :) Well thanks for fixing it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The styling of the TimeDimension Controller on the TimestampedGeoJson plugin was broken in my browser (chrome) due to the css-link being HTTP while running on an HTTPS site.
Used the content URL used in the Leaflet.TimeDimension Readme instead.