Pattern

[ColinTalbert]

This is my first attempt to author a plugin. It's working but I have a few concerns or questions.

The main one is that I need to pass a JS object with the pattern to the style_function. I did this by editing features.py to type check for branca MacroElements and passing their name to the output instead of themselves. Even still the name was getting passed enclosed in quotes, which I'm manually stripping for now. Ideas on an alternate or cleaner way to accomplish this business would be appreciated.

Also I wasn't quite sure how to structure the test.

here's the example:
http://nbviewer.jupyter.org/github/talbertc-usgs/folium/blob/pattern/examples/Pattern.ipynb

[jtbaker]

Cool PR, @talbertc-usgs! thanks for taking the time to submit.

[ocefpaf]

LGTM. Just waiting on @Conengmo's 👍 to merge it.

[Conengmo]

Hi @talbertc-usgs, I was checking out your PR and while doing that I made some changes:

• The pattern classes should always be added to a Map object.
• The pattern objects will be rendered in GeoJson.style_data() if they weren't added to anything. This means you no longer have to call stripes.add_to(m), which I assume many people would forget to do :)
• The test_pattern() test now uses a local data file instead of getting it from a URL.

Since I also made some changes/simplifications to GeoJson, I would like for @ocefpaf or @jtbaker to have a look as well.

Even still the name was getting passed enclosed in quotes, which I'm manually stripping for now.

It's not perfect but for now this seems a good solution.

[Conengmo]

@talbertc-usgs do you want to take a final look at this? I would like to go ahead with merging this :)

[Conengmo]

Hope you're not in the shutdown @talbertc-usgs? Anyway, thanks for making this PR! Hope you liked contributing to folium.

[ColinTalbert]

Hello Filipe and Frank, Thank you for reviewing and merging this PR. I was out on US government furlough so I'm just getting back to this now. Please let me know if there are any changes or improvements needed. Thanks, Colin

…

On Sat, Jan 12, 2019 at 4:13 AM Frank ***@***.***> wrote: Merged #966 <#966> into master. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#966 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AWHgaksQc8RglFtbByrRfLM3vXSF71Jqks5vCcNfgaJpZM4Wu9lF> .

[Conengmo]

Hi Colin, I think it’s good for now, but do try it out for yourself. If you want to help out again with folium you’re very welcome to.