Skip to content

Commit 11ae7d0

Browse files
bpo-40287: Fix SpooledTemporaryFile.seek() return value (GH-19540)
It has not returned the file position after the seek. (cherry picked from commit 485e715) Co-authored-by: Inada Naoki <[email protected]>
1 parent 6fd47fa commit 11ae7d0

File tree

3 files changed

+6
-3
lines changed

3 files changed

+6
-3
lines changed

Lib/tempfile.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -744,7 +744,7 @@ def readlines(self, *args):
744744
return self._file.readlines(*args)
745745

746746
def seek(self, *args):
747-
self._file.seek(*args)
747+
return self._file.seek(*args)
748748

749749
@property
750750
def softspace(self):

Lib/test/test_tempfile.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1034,7 +1034,8 @@ def test_writelines(self):
10341034
# Verify writelines with a SpooledTemporaryFile
10351035
f = self.do_create()
10361036
f.writelines((b'x', b'y', b'z'))
1037-
f.seek(0)
1037+
pos = f.seek(0)
1038+
self.assertEqual(pos, 0)
10381039
buf = f.read()
10391040
self.assertEqual(buf, b'xyz')
10401041

@@ -1052,7 +1053,8 @@ def test_sparse(self):
10521053
# when that occurs
10531054
f = self.do_create(max_size=30)
10541055
self.assertFalse(f._rolled)
1055-
f.seek(100, 0)
1056+
pos = f.seek(100, 0)
1057+
self.assertEqual(pos, 100)
10561058
self.assertFalse(f._rolled)
10571059
f.write(b'x')
10581060
self.assertTrue(f._rolled)
Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
Fixed ``SpooledTemporaryFile.seek()`` to return the position.

0 commit comments

Comments
 (0)