Skip to content

Commit 2332fed

Browse files
bpo-33761: Fix a file leak in test_iterparse in test_xml_etree. (GH-7358)
(cherry picked from commit 13f51d9) Co-authored-by: Serhiy Storchaka <[email protected]>
1 parent bdab3ea commit 2332fed

File tree

1 file changed

+5
-3
lines changed

1 file changed

+5
-3
lines changed

Lib/test/test_xml_etree.py

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -617,6 +617,7 @@ def test_iterparse(self):
617617
self.assertEqual(str(cm.exception),
618618
'junk after document element: line 1, column 12')
619619

620+
self.addCleanup(support.unlink, TESTFN)
620621
with open(TESTFN, "wb") as f:
621622
f.write(b"<document />junk")
622623
it = iterparse(TESTFN)
@@ -2849,9 +2850,6 @@ def test_setslice_negative_steps(self):
28492850

28502851

28512852
class IOTest(unittest.TestCase):
2852-
def tearDown(self):
2853-
support.unlink(TESTFN)
2854-
28552853
def test_encoding(self):
28562854
# Test encoding issues.
28572855
elem = ET.Element("tag")
@@ -2922,12 +2920,14 @@ def test_encoding(self):
29222920
"<tag key=\"åöö&lt;&gt;\" />" % enc).encode(enc))
29232921

29242922
def test_write_to_filename(self):
2923+
self.addCleanup(support.unlink, TESTFN)
29252924
tree = ET.ElementTree(ET.XML('''<site />'''))
29262925
tree.write(TESTFN)
29272926
with open(TESTFN, 'rb') as f:
29282927
self.assertEqual(f.read(), b'''<site />''')
29292928

29302929
def test_write_to_text_file(self):
2930+
self.addCleanup(support.unlink, TESTFN)
29312931
tree = ET.ElementTree(ET.XML('''<site />'''))
29322932
with open(TESTFN, 'w', encoding='utf-8') as f:
29332933
tree.write(f, encoding='unicode')
@@ -2936,6 +2936,7 @@ def test_write_to_text_file(self):
29362936
self.assertEqual(f.read(), b'''<site />''')
29372937

29382938
def test_write_to_binary_file(self):
2939+
self.addCleanup(support.unlink, TESTFN)
29392940
tree = ET.ElementTree(ET.XML('''<site />'''))
29402941
with open(TESTFN, 'wb') as f:
29412942
tree.write(f)
@@ -2944,6 +2945,7 @@ def test_write_to_binary_file(self):
29442945
self.assertEqual(f.read(), b'''<site />''')
29452946

29462947
def test_write_to_binary_file_with_bom(self):
2948+
self.addCleanup(support.unlink, TESTFN)
29472949
tree = ET.ElementTree(ET.XML('''<site />'''))
29482950
# test BOM writing to buffered file
29492951
with open(TESTFN, 'wb') as f:

0 commit comments

Comments
 (0)