Skip to content

bpo-33761: Fix a file leak in test_iterparse in test_xml_etree. #7358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

serhiy-storchaka
Copy link
Member

@serhiy-storchaka serhiy-storchaka commented Jun 3, 2018

@scoder
Copy link
Contributor

scoder commented Jun 3, 2018

Looks good to me.

@serhiy-storchaka serhiy-storchaka merged commit 13f51d9 into python:master Jun 3, 2018
@miss-islington
Copy link
Contributor

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.6, 3.7.
🐍🍒⛏🤖

@serhiy-storchaka serhiy-storchaka deleted the test_xml_etree-file-leak branch June 3, 2018 17:56
@bedevere-bot
Copy link

GH-7359 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 3, 2018
@bedevere-bot
Copy link

GH-7360 is a backport of this pull request to the 3.6 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 3, 2018
miss-islington added a commit that referenced this pull request Jun 3, 2018
)

(cherry picked from commit 13f51d9)

Co-authored-by: Serhiy Storchaka <[email protected]>
@miss-islington
Copy link
Contributor

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.6.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-7363 is a backport of this pull request to the 3.6 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 3, 2018
miss-islington added a commit that referenced this pull request Jun 4, 2018
)

(cherry picked from commit 13f51d9)

Co-authored-by: Serhiy Storchaka <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants