Skip to content

Commit a7de148

Browse files
bpo-33761: Fix a file leak in test_iterparse in test_xml_etree. (GH-7358)
(cherry picked from commit 13f51d9) Co-authored-by: Serhiy Storchaka <[email protected]>
1 parent 6a43d5f commit a7de148

File tree

1 file changed

+5
-3
lines changed

1 file changed

+5
-3
lines changed

Lib/test/test_xml_etree.py

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -606,6 +606,7 @@ def test_iterparse(self):
606606
self.assertEqual(str(cm.exception),
607607
'junk after document element: line 1, column 12')
608608

609+
self.addCleanup(support.unlink, TESTFN)
609610
with open(TESTFN, "wb") as f:
610611
f.write(b"<document />junk")
611612
it = iterparse(TESTFN)
@@ -2794,9 +2795,6 @@ def test_setslice_negative_steps(self):
27942795

27952796

27962797
class IOTest(unittest.TestCase):
2797-
def tearDown(self):
2798-
support.unlink(TESTFN)
2799-
28002798
def test_encoding(self):
28012799
# Test encoding issues.
28022800
elem = ET.Element("tag")
@@ -2867,12 +2865,14 @@ def test_encoding(self):
28672865
"<tag key=\"åöö&lt;&gt;\" />" % enc).encode(enc))
28682866

28692867
def test_write_to_filename(self):
2868+
self.addCleanup(support.unlink, TESTFN)
28702869
tree = ET.ElementTree(ET.XML('''<site />'''))
28712870
tree.write(TESTFN)
28722871
with open(TESTFN, 'rb') as f:
28732872
self.assertEqual(f.read(), b'''<site />''')
28742873

28752874
def test_write_to_text_file(self):
2875+
self.addCleanup(support.unlink, TESTFN)
28762876
tree = ET.ElementTree(ET.XML('''<site />'''))
28772877
with open(TESTFN, 'w', encoding='utf-8') as f:
28782878
tree.write(f, encoding='unicode')
@@ -2881,6 +2881,7 @@ def test_write_to_text_file(self):
28812881
self.assertEqual(f.read(), b'''<site />''')
28822882

28832883
def test_write_to_binary_file(self):
2884+
self.addCleanup(support.unlink, TESTFN)
28842885
tree = ET.ElementTree(ET.XML('''<site />'''))
28852886
with open(TESTFN, 'wb') as f:
28862887
tree.write(f)
@@ -2889,6 +2890,7 @@ def test_write_to_binary_file(self):
28892890
self.assertEqual(f.read(), b'''<site />''')
28902891

28912892
def test_write_to_binary_file_with_bom(self):
2893+
self.addCleanup(support.unlink, TESTFN)
28922894
tree = ET.ElementTree(ET.XML('''<site />'''))
28932895
# test BOM writing to buffered file
28942896
with open(TESTFN, 'wb') as f:

0 commit comments

Comments
 (0)