Skip to content

Commit 3185267

Browse files
bpo-41491: plistlib: accept hexadecimal integer values in xml plist files (GH-22764)
1 parent 109826c commit 3185267

File tree

3 files changed

+19
-1
lines changed

3 files changed

+19
-1
lines changed

Lib/plistlib.py

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -252,7 +252,11 @@ def end_false(self):
252252
self.add_object(False)
253253

254254
def end_integer(self):
255-
self.add_object(int(self.get_data()))
255+
raw = self.get_data()
256+
if raw.startswith('0x') or raw.startswith('0X'):
257+
self.add_object(int(raw, 16))
258+
else:
259+
self.add_object(int(raw))
256260

257261
def end_real(self):
258262
self.add_object(float(self.get_data()))

Lib/test/test_plistlib.py

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -498,6 +498,19 @@ def test_invalidreal(self):
498498
self.assertRaises(ValueError, plistlib.loads,
499499
b"<plist><integer>not real</integer></plist>")
500500

501+
def test_integer_notations(self):
502+
pl = b"<plist><integer>456</integer></plist>"
503+
value = plistlib.loads(pl)
504+
self.assertEqual(value, 456)
505+
506+
pl = b"<plist><integer>0xa</integer></plist>"
507+
value = plistlib.loads(pl)
508+
self.assertEqual(value, 10)
509+
510+
pl = b"<plist><integer>0123</integer></plist>"
511+
value = plistlib.loads(pl)
512+
self.assertEqual(value, 123)
513+
501514
def test_xml_encodings(self):
502515
base = TESTDATA[plistlib.FMT_XML]
503516

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
plistlib: fix parsing XML plists with hexadecimal integer values

0 commit comments

Comments
 (0)