bpo-41491: plistlib: accept hexadecimal integer values in xml plist f… #22764

ronaldoussoren · 2020-10-19T12:06:15Z

Turns out that Apple's plist parsing code accepts hexadecimal notation in tags.

https://bugs.python.org/issue41491

…iles

ned-deily

LGTM. I wonder if it would be worth opening a new issue to enhance test_plistlib to do some comparisons with the output from plutil when the test is running on macOS.

ronaldoussoren · 2020-10-20T07:25:19Z

I filed bpo-42095 for the additional tests. Having those would be useful to check interop, but wouldn't have found this particular issue.

miss-islington · 2020-10-20T07:26:37Z

Thanks @ronaldoussoren for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8, 3.9.
🐍🍒⛏🤖

bedevere-bot · 2020-10-20T07:26:49Z

GH-22806 is a backport of this pull request to the 3.9 branch.

…iles (pythonGH-22764) (cherry picked from commit 3185267) Co-authored-by: Ronald Oussoren <[email protected]>

bedevere-bot · 2020-10-20T07:26:56Z

GH-22807 is a backport of this pull request to the 3.8 branch.

…iles (GH-22764) (GH-22806) (cherry picked from commit 3185267) Co-authored-by: Ronald Oussoren <[email protected]>

…iles (GH-22764) (GH-22807) (cherry picked from commit 3185267) Co-authored-by: Ronald Oussoren <[email protected]> Co-authored-by: Ronald Oussoren <[email protected]>

bedevere-bot · 2020-10-20T08:22:25Z

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot s390x Fedora Clang 3.x has failed when building commit 3185267.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/3/builds/201) and take a look at the build logs.
Check if the failure is related to this commit (3185267) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/3/builds/201

Failed tests:

test_lib2to3

Summary of the results of the build (if available):

==

Click to see traceback logs

remote: Enumerating objects: 10, done.        
remote: Counting objects:  10% (1/10)        
remote: Counting objects:  20% (2/10)        
remote: Counting objects:  30% (3/10)        
remote: Counting objects:  40% (4/10)        
remote: Counting objects:  50% (5/10)        
remote: Counting objects:  60% (6/10)        
remote: Counting objects:  70% (7/10)        
remote: Counting objects:  80% (8/10)        
remote: Counting objects:  90% (9/10)        
remote: Counting objects: 100% (10/10)        
remote: Counting objects: 100% (10/10), done.        
remote: Compressing objects:  12% (1/8)        
remote: Compressing objects:  25% (2/8)        
remote: Compressing objects:  37% (3/8)        
remote: Compressing objects:  50% (4/8)        
remote: Compressing objects:  62% (5/8)        
remote: Compressing objects:  75% (6/8)        
remote: Compressing objects:  87% (7/8)        
remote: Compressing objects: 100% (8/8)        
remote: Compressing objects: 100% (8/8), done.        
remote: Total 11 (delta 2), reused 4 (delta 2), pack-reused 1        
From https://github.com/python/cpython
 * branch                  master     -> FETCH_HEAD
Reset branch 'master'

Python/pytime.c:154:10: warning: implicit conversion from 'long' to 'double' changes value from 9223372036854775807 to 9223372036854775808 [-Wimplicit-int-float-conversion]
    if (!_Py_InIntegralTypeRange(time_t, intpart)) {
         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
./Include/pymath.h:228:82: note: expanded from macro '_Py_InIntegralTypeRange'
#define _Py_InIntegralTypeRange(type, v) (_Py_IntegralTypeMin(type) <= v && v <= _Py_IntegralTypeMax(type))
                                                                              ~~ ^~~~~~~~~~~~~~~~~~~~~~~~~
./Include/pymath.h:221:124: note: expanded from macro '_Py_IntegralTypeMax'
#define _Py_IntegralTypeMax(type) ((_Py_IntegralTypeSigned(type)) ? (((((type)1 << (sizeof(type)*CHAR_BIT - 2)) - 1) << 1) + 1) : ~(type)0)
                                                                     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~
Python/pytime.c:207:14: warning: implicit conversion from 'long' to 'double' changes value from 9223372036854775807 to 9223372036854775808 [-Wimplicit-int-float-conversion]
        if (!_Py_InIntegralTypeRange(time_t, intpart)) {
             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
./Include/pymath.h:228:82: note: expanded from macro '_Py_InIntegralTypeRange'
#define _Py_InIntegralTypeRange(type, v) (_Py_IntegralTypeMin(type) <= v && v <= _Py_IntegralTypeMax(type))
                                                                              ~~ ^~~~~~~~~~~~~~~~~~~~~~~~~
./Include/pymath.h:221:124: note: expanded from macro '_Py_IntegralTypeMax'
#define _Py_IntegralTypeMax(type) ((_Py_IntegralTypeSigned(type)) ? (((((type)1 << (sizeof(type)*CHAR_BIT - 2)) - 1) << 1) + 1) : ~(type)0)
                                                                     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~
Python/pytime.c:392:10: warning: implicit conversion from 'long' to 'double' changes value from 9223372036854775807 to 9223372036854775808 [-Wimplicit-int-float-conversion]
    if (!_Py_InIntegralTypeRange(_PyTime_t, d)) {
         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
./Include/pymath.h:228:82: note: expanded from macro '_Py_InIntegralTypeRange'
#define _Py_InIntegralTypeRange(type, v) (_Py_IntegralTypeMin(type) <= v && v <= _Py_IntegralTypeMax(type))
                                                                              ~~ ^~~~~~~~~~~~~~~~~~~~~~~~~
./Include/pymath.h:221:124: note: expanded from macro '_Py_IntegralTypeMax'
#define _Py_IntegralTypeMax(type) ((_Py_IntegralTypeSigned(type)) ? (((((type)1 << (sizeof(type)*CHAR_BIT - 2)) - 1) << 1) + 1) : ~(type)0)
                                                                     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~
3 warnings generated.
./Modules/timemodule.c:116:13: warning: code will never be executed [-Wunreachable-code]
            PyErr_SetString(PyExc_OverflowError,
            ^~~~~~~~~~~~~~~
1 warning generated.
./Modules/_threadmodule.c:1587:19: warning: implicit conversion from '_PyTime_t' (aka 'long') to 'double' changes value from 9223372036854775 to 9223372036854776 [-Wimplicit-int-float-conversion]
    timeout_max = (_PyTime_t)PY_TIMEOUT_MAX * 1e-6;
                  ^~~~~~~~~~~~~~~~~~~~~~~~~ ~
1 warning generated.

test_zipfile64 skipped -- test requires loads of disk-space bytes and a long time to run
test_tk skipped -- Tk unavailable due to TclError: no display name and no $DISPLAY environment variab [...]
test_readline skipped -- No module named 'readline'
Fatal Python error: Segmentation fault

Current thread 0x000003ff99df8b20 (most recent call first):
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.clang/build/Lib/lib2to3/btm_matcher.py", line 125 in run
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.clang/build/Lib/lib2to3/refactor.py", line 414 in refactor_tree
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.clang/build/Lib/lib2to3/refactor.py", line 371 in refactor_string
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.clang/build/Lib/lib2to3/refactor.py", line 339 in refactor_file
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.clang/build/Lib/lib2to3/tests/test_all_fixers.py", line 24 in test_all_project_files
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.clang/build/Lib/unittest/case.py", line 549 in _callTestMethod
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.clang/build/Lib/unittest/case.py", line 592 in run
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.clang/build/Lib/unittest/case.py", line 652 in __call__
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.clang/build/Lib/unittest/suite.py", line 122 in run
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.clang/build/Lib/unittest/suite.py", line 84 in __call__
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.clang/build/Lib/unittest/suite.py", line 122 in run
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.clang/build/Lib/unittest/suite.py", line 84 in __call__
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.clang/build/Lib/unittest/suite.py", line 122 in run
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.clang/build/Lib/unittest/suite.py", line 84 in __call__
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.clang/build/Lib/unittest/suite.py", line 122 in run
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.clang/build/Lib/unittest/suite.py", line 84 in __call__
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.clang/build/Lib/unittest/suite.py", line 122 in run
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.clang/build/Lib/unittest/suite.py", line 84 in __call__
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.clang/build/Lib/unittest/runner.py", line 176 in run
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.clang/build/Lib/test/support/__init__.py", line 959 in _run_suite
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.clang/build/Lib/test/support/__init__.py", line 1082 in run_unittest
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.clang/build/Lib/test/libregrtest/runtest.py", line 211 in _test_module
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.clang/build/Lib/test/libregrtest/runtest.py", line 236 in _runtest_inner2
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.clang/build/Lib/test/libregrtest/runtest.py", line 272 in _runtest_inner
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.clang/build/Lib/test/libregrtest/runtest.py", line 142 in _runtest
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.clang/build/Lib/test/libregrtest/runtest.py", line 195 in runtest
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.clang/build/Lib/test/libregrtest/runtest_mp.py", line 81 in run_tests_worker
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.clang/build/Lib/test/libregrtest/main.py", line 659 in _main
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.clang/build/Lib/test/libregrtest/main.py", line 639 in main
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.clang/build/Lib/test/libregrtest/main.py", line 717 in main
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.clang/build/Lib/test/regrtest.py", line 43 in _main
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.clang/build/Lib/test/regrtest.py", line 47 in <module>
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.clang/build/Lib/runpy.py", line 87 in _run_code
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.clang/build/Lib/runpy.py", line 197 in _run_module_as_main
test_devpoll skipped -- test works only on Solaris OS family
test_nis skipped -- No module named 'nis'
test_startfile skipped -- object <module 'os' from '/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.clang/build/Lib/os.py'> has no attribute 'startfile'
test_ttk_guionly skipped -- Tk unavailable due to TclError: no display name and no $DISPLAY environment variab [...]
test_winconsoleio skipped -- test only relevant on win32
test_msilib skipped -- No module named '_msi'
test_winreg skipped -- No module named 'winreg'
test_winsound skipped -- No module named 'winsound'
test_tix skipped -- Tk unavailable due to TclError: no display name and no $DISPLAY environment variab [...]
test_kqueue skipped -- test works only on BSD
test_ossaudiodev skipped -- [Errno 2] No such file or directory: '/dev/dsp'
test_ioctl skipped -- Unable to open /dev/tty
test_flock (__main__.FNTLEINTRTest) ... ok
test_lockf (__main__.FNTLEINTRTest) ... ok
test_read (__main__.OSEINTRTest) ... ok
test_wait (__main__.OSEINTRTest) ... ok
test_wait3 (__main__.OSEINTRTest) ... ok
test_wait4 (__main__.OSEINTRTest) ... ok
test_waitpid (__main__.OSEINTRTest) ... ok
test_write (__main__.OSEINTRTest) ... ok
test_devpoll (__main__.SelectEINTRTest) ... skipped 'need select.devpoll'
test_epoll (__main__.SelectEINTRTest) ... ok
test_kqueue (__main__.SelectEINTRTest) ... skipped 'need select.kqueue'
test_poll (__main__.SelectEINTRTest) ... ok
test_select (__main__.SelectEINTRTest) ... ok
test_sigtimedwait (__main__.SignalEINTRTest) ... ok
test_sigwaitinfo (__main__.SignalEINTRTest) ... ok
test_accept (__main__.SocketEINTRTest) ... ok
test_open (__main__.SocketEINTRTest) ... ok
test_os_open (__main__.SocketEINTRTest) ... ok
test_recv (__main__.SocketEINTRTest) ... ok
test_recvmsg (__main__.SocketEINTRTest) ... ok
test_send (__main__.SocketEINTRTest) ... ok
test_sendall (__main__.SocketEINTRTest) ... ok
test_sendmsg (__main__.SocketEINTRTest) ... ok
test_sleep (__main__.TimeEINTRTest) ... ok

----------------------------------------------------------------------
Ran 24 tests in 6.527s

OK (skipped=2)
/tmp/tmp6qhqo5te/parse.c:136:19: warning: code will never be executed [-Wunreachable-code]
        p->mark = _mark;
                  ^~~~~
1 warning generated.
Fatal Python error: Segmentation fault

Current thread 0x000003ffb56f8b20 (most recent call first):
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.clang/build/Lib/lib2to3/btm_matcher.py", line 125 in run
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.clang/build/Lib/lib2to3/refactor.py", line 458 in refactor_tree
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.clang/build/Lib/lib2to3/refactor.py", line 371 in refactor_string
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.clang/build/Lib/lib2to3/refactor.py", line 339 in refactor_file
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.clang/build/Lib/lib2to3/tests/test_all_fixers.py", line 24 in test_all_project_files
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.clang/build/Lib/unittest/case.py", line 549 in _callTestMethod
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.clang/build/Lib/unittest/case.py", line 592 in run
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.clang/build/Lib/unittest/case.py", line 652 in __call__
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.clang/build/Lib/unittest/suite.py", line 122 in run
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.clang/build/Lib/unittest/suite.py", line 84 in __call__
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.clang/build/Lib/unittest/suite.py", line 122 in run
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.clang/build/Lib/unittest/suite.py", line 84 in __call__
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.clang/build/Lib/unittest/suite.py", line 122 in run
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.clang/build/Lib/unittest/suite.py", line 84 in __call__
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.clang/build/Lib/unittest/suite.py", line 122 in run
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.clang/build/Lib/unittest/suite.py", line 84 in __call__
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.clang/build/Lib/unittest/suite.py", line 122 in run
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.clang/build/Lib/unittest/suite.py", line 84 in __call__
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.clang/build/Lib/unittest/runner.py", line 176 in run
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.clang/build/Lib/test/support/__init__.py", line 959 in _run_suite
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.clang/build/Lib/test/support/__init__.py", line 1082 in run_unittest
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.clang/build/Lib/test/libregrtest/runtest.py", line 211 in _test_module
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.clang/build/Lib/test/libregrtest/runtest.py", line 236 in _runtest_inner2
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.clang/build/Lib/test/libregrtest/runtest.py", line 272 in _runtest_inner
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.clang/build/Lib/test/libregrtest/runtest.py", line 155 in _runtest
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.clang/build/Lib/test/libregrtest/runtest.py", line 195 in runtest
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.clang/build/Lib/test/libregrtest/main.py", line 319 in rerun_failed_tests
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.clang/build/Lib/test/libregrtest/main.py", line 696 in _main
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.clang/build/Lib/test/libregrtest/main.py", line 639 in main
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.clang/build/Lib/test/libregrtest/main.py", line 717 in main
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.clang/build/Lib/test/__main__.py", line 2 in <module>
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.clang/build/Lib/runpy.py", line 87 in _run_code
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.clang/build/Lib/runpy.py", line 197 in _run_module_as_main
make: *** [Makefile:1199: buildbottest] Segmentation fault (core dumped)

Cannot open file '/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.clang/build/test-results.xml' for upload

bedevere-bot · 2020-10-20T08:28:47Z

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot s390x Fedora Clang Installed 3.x has failed when building commit 3185267.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/531/builds/192) and take a look at the build logs.
Check if the failure is related to this commit (3185267) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/531/builds/192

Failed tests:

test_lib2to3

Summary of the results of the build (if available):

==

Click to see traceback logs

remote: Enumerating objects: 10, done.        
remote: Counting objects:  10% (1/10)        
remote: Counting objects:  20% (2/10)        
remote: Counting objects:  30% (3/10)        
remote: Counting objects:  40% (4/10)        
remote: Counting objects:  50% (5/10)        
remote: Counting objects:  60% (6/10)        
remote: Counting objects:  70% (7/10)        
remote: Counting objects:  80% (8/10)        
remote: Counting objects:  90% (9/10)        
remote: Counting objects: 100% (10/10)        
remote: Counting objects: 100% (10/10), done.        
remote: Compressing objects:  12% (1/8)        
remote: Compressing objects:  25% (2/8)        
remote: Compressing objects:  37% (3/8)        
remote: Compressing objects:  50% (4/8)        
remote: Compressing objects:  62% (5/8)        
remote: Compressing objects:  75% (6/8)        
remote: Compressing objects:  87% (7/8)        
remote: Compressing objects: 100% (8/8)        
remote: Compressing objects: 100% (8/8), done.        
remote: Total 11 (delta 2), reused 10 (delta 2), pack-reused 1        
From https://github.com/python/cpython
 * branch                  master     -> FETCH_HEAD
Reset branch 'master'

Python/pytime.c:154:10: warning: implicit conversion from 'long' to 'double' changes value from 9223372036854775807 to 9223372036854775808 [-Wimplicit-int-float-conversion]
    if (!_Py_InIntegralTypeRange(time_t, intpart)) {
         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
./Include/pymath.h:228:82: note: expanded from macro '_Py_InIntegralTypeRange'
#define _Py_InIntegralTypeRange(type, v) (_Py_IntegralTypeMin(type) <= v && v <= _Py_IntegralTypeMax(type))
                                                                              ~~ ^~~~~~~~~~~~~~~~~~~~~~~~~
./Include/pymath.h:221:124: note: expanded from macro '_Py_IntegralTypeMax'
#define _Py_IntegralTypeMax(type) ((_Py_IntegralTypeSigned(type)) ? (((((type)1 << (sizeof(type)*CHAR_BIT - 2)) - 1) << 1) + 1) : ~(type)0)
                                                                     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~
Python/pytime.c:207:14: warning: implicit conversion from 'long' to 'double' changes value from 9223372036854775807 to 9223372036854775808 [-Wimplicit-int-float-conversion]
        if (!_Py_InIntegralTypeRange(time_t, intpart)) {
             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
./Include/pymath.h:228:82: note: expanded from macro '_Py_InIntegralTypeRange'
#define _Py_InIntegralTypeRange(type, v) (_Py_IntegralTypeMin(type) <= v && v <= _Py_IntegralTypeMax(type))
                                                                              ~~ ^~~~~~~~~~~~~~~~~~~~~~~~~
./Include/pymath.h:221:124: note: expanded from macro '_Py_IntegralTypeMax'
#define _Py_IntegralTypeMax(type) ((_Py_IntegralTypeSigned(type)) ? (((((type)1 << (sizeof(type)*CHAR_BIT - 2)) - 1) << 1) + 1) : ~(type)0)
                                                                     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~
Python/pytime.c:392:10: warning: implicit conversion from 'long' to 'double' changes value from 9223372036854775807 to 9223372036854775808 [-Wimplicit-int-float-conversion]
    if (!_Py_InIntegralTypeRange(_PyTime_t, d)) {
         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
./Include/pymath.h:228:82: note: expanded from macro '_Py_InIntegralTypeRange'
#define _Py_InIntegralTypeRange(type, v) (_Py_IntegralTypeMin(type) <= v && v <= _Py_IntegralTypeMax(type))
                                                                              ~~ ^~~~~~~~~~~~~~~~~~~~~~~~~
./Include/pymath.h:221:124: note: expanded from macro '_Py_IntegralTypeMax'
#define _Py_IntegralTypeMax(type) ((_Py_IntegralTypeSigned(type)) ? (((((type)1 << (sizeof(type)*CHAR_BIT - 2)) - 1) << 1) + 1) : ~(type)0)
                                                                     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~
3 warnings generated.
./Modules/timemodule.c:116:13: warning: code will never be executed [-Wunreachable-code]
            PyErr_SetString(PyExc_OverflowError,
            ^~~~~~~~~~~~~~~
./Modules/_threadmodule.c:1587:19: warning: implicit conversion from '_PyTime_t' (aka 'long') to 'double' changes value from 9223372036854775 to 9223372036854776 [-Wimplicit-int-float-conversion]
    timeout_max = (_PyTime_t)PY_TIMEOUT_MAX * 1e-6;
                  ^~~~~~~~~~~~~~~~~~~~~~~~~ ~
1 warning generated.
1 warning generated.

  WARNING: The script easy_install-3.10 is installed in '/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.clang-installed/build/target/bin' which is not on PATH.
  Consider adding this directory to PATH or, if you prefer to suppress this warning, use --no-warn-script-location.
  WARNING: The scripts pip3 and pip3.10 are installed in '/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.clang-installed/build/target/bin' which is not on PATH.
  Consider adding this directory to PATH or, if you prefer to suppress this warning, use --no-warn-script-location.

test_asdl_parser skipped -- test irrelevant for an installed Python
test_ttk_guionly skipped -- Tk unavailable due to TclError: no display name and no $DISPLAY environment variab [...]
test_winconsoleio skipped -- test only relevant on win32
test_startfile skipped -- object <module 'os' from '/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.clang-installed/build/target/lib/python3.10/os.py'> has no attribute 'startfile'
test_ossaudiodev skipped -- [Errno 2] No such file or directory: '/dev/dsp'
test_nis skipped -- No module named 'nis'
test_winsound skipped -- No module named 'winsound'
test_readline skipped -- No module named 'readline'
test_tk skipped -- Tk unavailable due to TclError: no display name and no $DISPLAY environment variab [...]
test_gdb skipped -- test_gdb only works on source builds at the moment.
test_tix skipped -- Tk unavailable due to TclError: no display name and no $DISPLAY environment variab [...]
test_flock (__main__.FNTLEINTRTest) ... ok
test_lockf (__main__.FNTLEINTRTest) ... ok
test_read (__main__.OSEINTRTest) ... ok
test_wait (__main__.OSEINTRTest) ... ok
test_wait3 (__main__.OSEINTRTest) ... ok
test_wait4 (__main__.OSEINTRTest) ... ok
test_waitpid (__main__.OSEINTRTest) ... ok
test_write (__main__.OSEINTRTest) ... ok
test_devpoll (__main__.SelectEINTRTest) ... skipped 'need select.devpoll'
test_epoll (__main__.SelectEINTRTest) ... ok
test_kqueue (__main__.SelectEINTRTest) ... skipped 'need select.kqueue'
test_poll (__main__.SelectEINTRTest) ... ok
test_select (__main__.SelectEINTRTest) ... ok
test_sigtimedwait (__main__.SignalEINTRTest) ... ok
test_sigwaitinfo (__main__.SignalEINTRTest) ... ok
test_accept (__main__.SocketEINTRTest) ... ok
test_open (__main__.SocketEINTRTest) ... ok
test_os_open (__main__.SocketEINTRTest) ... ok
test_recv (__main__.SocketEINTRTest) ... ok
test_recvmsg (__main__.SocketEINTRTest) ... ok
test_send (__main__.SocketEINTRTest) ... ok
test_sendall (__main__.SocketEINTRTest) ... ok
test_sendmsg (__main__.SocketEINTRTest) ... ok
test_sleep (__main__.TimeEINTRTest) ... ok

----------------------------------------------------------------------
Ran 24 tests in 6.262s

OK (skipped=2)
test_msilib skipped -- No module named 'msilib'
test_winreg skipped -- No module named 'winreg'
test_ioctl skipped -- Unable to open /dev/tty
Fatal Python error: Segmentation fault

Current thread 0x000003ffa5778b20 (most recent call first):
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.clang-installed/build/target/lib/python3.10/lib2to3/btm_matcher.py", line 125 in run
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.clang-installed/build/target/lib/python3.10/lib2to3/refactor.py", line 414 in refactor_tree
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.clang-installed/build/target/lib/python3.10/lib2to3/refactor.py", line 371 in refactor_string
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.clang-installed/build/target/lib/python3.10/lib2to3/refactor.py", line 339 in refactor_file
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.clang-installed/build/target/lib/python3.10/lib2to3/tests/test_all_fixers.py", line 24 in test_all_project_files
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.clang-installed/build/target/lib/python3.10/unittest/case.py", line 549 in _callTestMethod
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.clang-installed/build/target/lib/python3.10/unittest/case.py", line 592 in run
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.clang-installed/build/target/lib/python3.10/unittest/case.py", line 652 in __call__
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.clang-installed/build/target/lib/python3.10/unittest/suite.py", line 122 in run
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.clang-installed/build/target/lib/python3.10/unittest/suite.py", line 84 in __call__
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.clang-installed/build/target/lib/python3.10/unittest/suite.py", line 122 in run
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.clang-installed/build/target/lib/python3.10/unittest/suite.py", line 84 in __call__
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.clang-installed/build/target/lib/python3.10/unittest/suite.py", line 122 in run
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.clang-installed/build/target/lib/python3.10/unittest/suite.py", line 84 in __call__
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.clang-installed/build/target/lib/python3.10/unittest/suite.py", line 122 in run
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.clang-installed/build/target/lib/python3.10/unittest/suite.py", line 84 in __call__
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.clang-installed/build/target/lib/python3.10/unittest/suite.py", line 122 in run
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.clang-installed/build/target/lib/python3.10/unittest/suite.py", line 84 in __call__
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.clang-installed/build/target/lib/python3.10/unittest/runner.py", line 176 in run
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.clang-installed/build/target/lib/python3.10/test/support/__init__.py", line 959 in _run_suite
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.clang-installed/build/target/lib/python3.10/test/support/__init__.py", line 1082 in run_unittest
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.clang-installed/build/target/lib/python3.10/test/libregrtest/runtest.py", line 211 in _test_module
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.clang-installed/build/target/lib/python3.10/test/libregrtest/runtest.py", line 236 in _runtest_inner2
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.clang-installed/build/target/lib/python3.10/test/libregrtest/runtest.py", line 272 in _runtest_inner
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.clang-installed/build/target/lib/python3.10/test/libregrtest/runtest.py", line 142 in _runtest
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.clang-installed/build/target/lib/python3.10/test/libregrtest/runtest.py", line 195 in runtest
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.clang-installed/build/target/lib/python3.10/test/libregrtest/runtest_mp.py", line 81 in run_tests_worker
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.clang-installed/build/target/lib/python3.10/test/libregrtest/main.py", line 659 in _main
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.clang-installed/build/target/lib/python3.10/test/libregrtest/main.py", line 639 in main
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.clang-installed/build/target/lib/python3.10/test/libregrtest/main.py", line 717 in main
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.clang-installed/build/target/lib/python3.10/test/regrtest.py", line 43 in _main
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.clang-installed/build/target/lib/python3.10/test/regrtest.py", line 47 in <module>
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.clang-installed/build/target/lib/python3.10/runpy.py", line 87 in _run_code
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.clang-installed/build/target/lib/python3.10/runpy.py", line 197 in _run_module_as_main
test_devpoll skipped -- test works only on Solaris OS family
test_kqueue skipped -- test works only on BSD
test_zipfile64 skipped -- test requires loads of disk-space bytes and a long time to run
test_clinic skipped -- clinic directory could not be found
test_check_c_globals skipped -- c-analyzer directory could not be found
Fatal Python error: Segmentation fault

Current thread 0x000003ffa6bf8b20 (most recent call first):
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.clang-installed/build/target/lib/python3.10/lib2to3/btm_matcher.py", line 125 in run
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.clang-installed/build/target/lib/python3.10/lib2to3/refactor.py", line 414 in refactor_tree
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.clang-installed/build/target/lib/python3.10/lib2to3/refactor.py", line 371 in refactor_string
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.clang-installed/build/target/lib/python3.10/lib2to3/refactor.py", line 339 in refactor_file
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.clang-installed/build/target/lib/python3.10/lib2to3/tests/test_all_fixers.py", line 24 in test_all_project_files
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.clang-installed/build/target/lib/python3.10/unittest/case.py", line 549 in _callTestMethod
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.clang-installed/build/target/lib/python3.10/unittest/case.py", line 592 in run
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.clang-installed/build/target/lib/python3.10/unittest/case.py", line 652 in __call__
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.clang-installed/build/target/lib/python3.10/unittest/suite.py", line 122 in run
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.clang-installed/build/target/lib/python3.10/unittest/suite.py", line 84 in __call__
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.clang-installed/build/target/lib/python3.10/unittest/suite.py", line 122 in run
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.clang-installed/build/target/lib/python3.10/unittest/suite.py", line 84 in __call__
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.clang-installed/build/target/lib/python3.10/unittest/suite.py", line 122 in run
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.clang-installed/build/target/lib/python3.10/unittest/suite.py", line 84 in __call__
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.clang-installed/build/target/lib/python3.10/unittest/suite.py", line 122 in run
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.clang-installed/build/target/lib/python3.10/unittest/suite.py", line 84 in __call__
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.clang-installed/build/target/lib/python3.10/unittest/suite.py", line 122 in run
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.clang-installed/build/target/lib/python3.10/unittest/suite.py", line 84 in __call__
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.clang-installed/build/target/lib/python3.10/unittest/runner.py", line 176 in run
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.clang-installed/build/target/lib/python3.10/test/support/__init__.py", line 959 in _run_suite
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.clang-installed/build/target/lib/python3.10/test/support/__init__.py", line 1082 in run_unittest
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.clang-installed/build/target/lib/python3.10/test/libregrtest/runtest.py", line 211 in _test_module
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.clang-installed/build/target/lib/python3.10/test/libregrtest/runtest.py", line 236 in _runtest_inner2
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.clang-installed/build/target/lib/python3.10/test/libregrtest/runtest.py", line 272 in _runtest_inner
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.clang-installed/build/target/lib/python3.10/test/libregrtest/runtest.py", line 155 in _runtest
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.clang-installed/build/target/lib/python3.10/test/libregrtest/runtest.py", line 195 in runtest
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.clang-installed/build/target/lib/python3.10/test/libregrtest/main.py", line 319 in rerun_failed_tests
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.clang-installed/build/target/lib/python3.10/test/libregrtest/main.py", line 696 in _main
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.clang-installed/build/target/lib/python3.10/test/libregrtest/main.py", line 639 in main
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.clang-installed/build/target/lib/python3.10/test/libregrtest/main.py", line 717 in main
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.clang-installed/build/target/lib/python3.10/test/regrtest.py", line 43 in _main
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.clang-installed/build/target/lib/python3.10/test/regrtest.py", line 47 in <module>
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.clang-installed/build/target/lib/python3.10/runpy.py", line 87 in _run_code
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.clang-installed/build/target/lib/python3.10/runpy.py", line 197 in _run_module_as_main

bedevere-bot · 2020-10-20T08:56:25Z

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot s390x Fedora LTO 3.x has failed when building commit 3185267.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/55/builds/228) and take a look at the build logs.
Check if the failure is related to this commit (3185267) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/55/builds/228

Failed tests:

test_lib2to3

Summary of the results of the build (if available):

==

Click to see traceback logs

remote: Enumerating objects: 1        
remote: Enumerating objects: 10, done.        
remote: Counting objects:  10% (1/10)        
remote: Counting objects:  20% (2/10)        
remote: Counting objects:  30% (3/10)        
remote: Counting objects:  40% (4/10)        
remote: Counting objects:  50% (5/10)        
remote: Counting objects:  60% (6/10)        
remote: Counting objects:  70% (7/10)        
remote: Counting objects:  80% (8/10)        
remote: Counting objects:  90% (9/10)        
remote: Counting objects: 100% (10/10)        
remote: Counting objects: 100% (10/10), done.        
remote: Compressing objects:  12% (1/8)        
remote: Compressing objects:  25% (2/8)        
remote: Compressing objects:  37% (3/8)        
remote: Compressing objects:  50% (4/8)        
remote: Compressing objects:  62% (5/8)        
remote: Compressing objects:  75% (6/8)        
remote: Compressing objects:  87% (7/8)        
remote: Compressing objects: 100% (8/8)        
remote: Compressing objects: 100% (8/8), done.        
remote: Total 11 (delta 2), reused 10 (delta 2), pack-reused 1        
From https://github.com/python/cpython
 * branch                  master     -> FETCH_HEAD
Reset branch 'master'

In function ‘bytearray_removeprefix_impl’,
    inlined from ‘bytearray_removeprefix’ at Objects/clinic/bytearrayobject.c.h:139:20:
Objects/bytearrayobject.c:1204:12: warning: ‘__builtin_memcmp_eq’ specified size between 9223372036854775808 and 18446744073709551615 exceeds maximum object size 9223372036854775807 [-Wstringop-overflow=]
 1204 |         && memcmp(self_start, prefix_start, prefix_len) == 0)
      |            ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In function ‘bytearray_removesuffix_impl’,
    inlined from ‘bytearray_removesuffix’ at Objects/clinic/bytearrayobject.c.h:179:20:
Objects/bytearrayobject.c:1236:12: warning: ‘__builtin_memcmp_eq’ specified size between 9223372036854775808 and 18446744073709551615 exceeds maximum object size 9223372036854775807 [-Wstringop-overflow=]
 1236 |         && memcmp(self_start + self_len - suffix_len,
      |            ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
 1237 |                   suffix_start, suffix_len) == 0)
      |                   ~~~~~~~~~~~~~~~~~~~~~~~~~
In function ‘assemble_lnotab’,
    inlined from ‘assemble_emit’ at Python/compile.c:5696:25,
    inlined from ‘assemble’ at Python/compile.c:6038:18:
Python/compile.c:5612:23: warning: writing 1 byte into a region of size 0 [-Wstringop-overflow=]
 5612 |             *lnotab++ = 255;
      |             ~~~~~~~~~~^~~~~
Python/compile.c:5613:23: warning: writing 1 byte into a region of size 0 [-Wstringop-overflow=]
 5613 |             *lnotab++ = 0;
      |             ~~~~~~~~~~^~~
Python/compile.c:5650:19: warning: writing 1 byte into a region of size 0 [-Wstringop-overflow=]
 5650 |         *lnotab++ = k;
      |         ~~~~~~~~~~^~~
In function ‘bytearray_removeprefix_impl’,
    inlined from ‘bytearray_removeprefix’ at Objects/clinic/bytearrayobject.c.h:139:20:
Objects/bytearrayobject.c:1204:12: warning: ‘__builtin_memcmp_eq’ specified size between 9223372036854775808 and 18446744073709551615 exceeds maximum object size 9223372036854775807 [-Wstringop-overflow=]
 1204 |         && memcmp(self_start, prefix_start, prefix_len) == 0)
      |            ^
In function ‘bytearray_removesuffix_impl’,
    inlined from ‘bytearray_removesuffix’ at Objects/clinic/bytearrayobject.c.h:179:20:
Objects/bytearrayobject.c:1236:12: warning: ‘__builtin_memcmp_eq’ specified size between 9223372036854775808 and 18446744073709551615 exceeds maximum object size 9223372036854775807 [-Wstringop-overflow=]
 1236 |         && memcmp(self_start + self_len - suffix_len,
      |            ^
In function ‘assemble_lnotab’,
    inlined from ‘assemble_emit’ at Python/compile.c:5696:25,
    inlined from ‘assemble’ at Python/compile.c:6038:18:
Python/compile.c:5612:23: warning: writing 1 byte into a region of size 0 [-Wstringop-overflow=]
 5612 |             *lnotab++ = 255;
      |                       ^
Python/compile.c:5613:23: warning: writing 1 byte into a region of size 0 [-Wstringop-overflow=]
 5613 |             *lnotab++ = 0;
      |                       ^
Python/compile.c:5650:19: warning: writing 1 byte into a region of size 0 [-Wstringop-overflow=]
 5650 |         *lnotab++ = k;
      |                   ^
In function ‘assemble_lnotab’,
    inlined from ‘assemble_emit’ at Python/compile.c:5696:0,
    inlined from ‘assemble’ at Python/compile.c:6038:0:
Python/compile.c:5612: warning: writing 1 byte into a region of size 0 [-Wstringop-overflow=]
 5612 |             *lnotab++ = 255;
      | 
Python/compile.c:5613: warning: writing 1 byte into a region of size 0 [-Wstringop-overflow=]
 5613 |             *lnotab++ = 0;
      | 
Python/compile.c:5650: warning: writing 1 byte into a region of size 0 [-Wstringop-overflow=]
 5650 |         *lnotab++ = k;
      | 
In function ‘assemble_lnotab’,
    inlined from ‘assemble_emit’ at Python/compile.c:5696:0,
    inlined from ‘assemble’ at Python/compile.c:6038:0:
Python/compile.c:5612: warning: writing 1 byte into a region of size 0 [-Wstringop-overflow=]
 5612 |             *lnotab++ = 255;
      | 
Python/compile.c:5613: warning: writing 1 byte into a region of size 0 [-Wstringop-overflow=]
 5613 |             *lnotab++ = 0;
      | 
Python/compile.c:5650: warning: writing 1 byte into a region of size 0 [-Wstringop-overflow=]
 5650 |         *lnotab++ = k;
      | 
/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.lto/build/Modules/_ctypes/callproc.c: In function ‘_ctypes_callproc’:
/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.lto/build/Modules/_ctypes/callproc.c:857:18: warning: ‘space’ may be used uninitialized in this function [-Wmaybe-uninitialized]
  857 |         space[0] = errno;
      |                  ^
/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.lto/build/Modules/_ctypes/callproc.c:819:10: note: ‘space’ was declared here
  819 |     int *space;
      |          ^~~~~

test_winreg skipped -- No module named 'winreg'
test_ioctl skipped -- Unable to open /dev/tty
test_winconsoleio skipped -- test only relevant on win32
test_nis skipped -- No module named 'nis'
test_tix skipped -- Tk unavailable due to TclError: no display name and no $DISPLAY environment variab [...]
test_ossaudiodev skipped -- [Errno 2] No such file or directory: '/dev/dsp'
test_kqueue skipped -- test works only on BSD
test_devpoll skipped -- test works only on Solaris OS family
test_startfile skipped -- object <module 'os' from '/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.lto/build/Lib/os.py'> has no attribute 'startfile'
test_msilib skipped -- No module named '_msi'
test_ttk_guionly skipped -- Tk unavailable due to TclError: no display name and no $DISPLAY environment variab [...]
Fatal Python error: Segmentation fault

Current thread 0x000003ffa4f78b20 (most recent call first):
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.lto/build/Lib/lib2to3/btm_matcher.py", line 125 in run
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.lto/build/Lib/lib2to3/refactor.py", line 414 in refactor_tree
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.lto/build/Lib/lib2to3/refactor.py", line 371 in refactor_string
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.lto/build/Lib/lib2to3/refactor.py", line 339 in refactor_file
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.lto/build/Lib/lib2to3/tests/test_all_fixers.py", line 24 in test_all_project_files
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.lto/build/Lib/unittest/case.py", line 549 in _callTestMethod
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.lto/build/Lib/unittest/case.py", line 592 in run
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.lto/build/Lib/unittest/case.py", line 652 in __call__
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.lto/build/Lib/unittest/suite.py", line 122 in run
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.lto/build/Lib/unittest/suite.py", line 84 in __call__
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.lto/build/Lib/unittest/suite.py", line 122 in run
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.lto/build/Lib/unittest/suite.py", line 84 in __call__
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.lto/build/Lib/unittest/suite.py", line 122 in run
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.lto/build/Lib/unittest/suite.py", line 84 in __call__
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.lto/build/Lib/unittest/suite.py", line 122 in run
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.lto/build/Lib/unittest/suite.py", line 84 in __call__
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.lto/build/Lib/unittest/suite.py", line 122 in run
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.lto/build/Lib/unittest/suite.py", line 84 in __call__
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.lto/build/Lib/unittest/runner.py", line 176 in run
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.lto/build/Lib/test/support/__init__.py", line 959 in _run_suite
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.lto/build/Lib/test/support/__init__.py", line 1082 in run_unittest
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.lto/build/Lib/test/libregrtest/runtest.py", line 211 in _test_module
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.lto/build/Lib/test/libregrtest/runtest.py", line 236 in _runtest_inner2
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.lto/build/Lib/test/libregrtest/runtest.py", line 272 in _runtest_inner
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.lto/build/Lib/test/libregrtest/runtest.py", line 142 in _runtest
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.lto/build/Lib/test/libregrtest/runtest.py", line 195 in runtest
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.lto/build/Lib/test/libregrtest/runtest_mp.py", line 81 in run_tests_worker
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.lto/build/Lib/test/libregrtest/main.py", line 659 in _main
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.lto/build/Lib/test/libregrtest/main.py", line 639 in main
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.lto/build/Lib/test/libregrtest/main.py", line 717 in main
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.lto/build/Lib/test/regrtest.py", line 43 in _main
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.lto/build/Lib/test/regrtest.py", line 47 in <module>
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.lto/build/Lib/runpy.py", line 87 in _run_code
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.lto/build/Lib/runpy.py", line 197 in _run_module_as_main
test_winsound skipped -- No module named 'winsound'
test_flock (__main__.FNTLEINTRTest) ... ok
test_lockf (__main__.FNTLEINTRTest) ... ok
test_read (__main__.OSEINTRTest) ... ok
test_wait (__main__.OSEINTRTest) ... ok
test_wait3 (__main__.OSEINTRTest) ... ok
test_wait4 (__main__.OSEINTRTest) ... ok
test_waitpid (__main__.OSEINTRTest) ... ok
test_write (__main__.OSEINTRTest) ... ok
test_devpoll (__main__.SelectEINTRTest) ... skipped 'need select.devpoll'
test_epoll (__main__.SelectEINTRTest) ... ok
test_kqueue (__main__.SelectEINTRTest) ... skipped 'need select.kqueue'
test_poll (__main__.SelectEINTRTest) ... ok
test_select (__main__.SelectEINTRTest) ... ok
test_sigtimedwait (__main__.SignalEINTRTest) ... ok
test_sigwaitinfo (__main__.SignalEINTRTest) ... ok
test_accept (__main__.SocketEINTRTest) ... ok
test_open (__main__.SocketEINTRTest) ... ok
test_os_open (__main__.SocketEINTRTest) ... ok
test_recv (__main__.SocketEINTRTest) ... ok
test_recvmsg (__main__.SocketEINTRTest) ... ok
test_send (__main__.SocketEINTRTest) ... ok
test_sendall (__main__.SocketEINTRTest) ... ok
test_sendmsg (__main__.SocketEINTRTest) ... ok
test_sleep (__main__.TimeEINTRTest) ... ok

----------------------------------------------------------------------
Ran 24 tests in 6.340s

OK (skipped=2)
test_readline skipped -- No module named 'readline'
test_tk skipped -- Tk unavailable due to TclError: no display name and no $DISPLAY environment variab [...]
test_zipfile64 skipped -- test requires loads of disk-space bytes and a long time to run
Fatal Python error: Segmentation fault

Current thread 0x000003ff91078b20 (most recent call first):
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.lto/build/Lib/lib2to3/btm_matcher.py", line 125 in run
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.lto/build/Lib/lib2to3/refactor.py", line 414 in refactor_tree
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.lto/build/Lib/lib2to3/refactor.py", line 371 in refactor_string
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.lto/build/Lib/lib2to3/tests/test_fixers.py", line 31 in _check
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.lto/build/Lib/lib2to3/tests/test_fixers.py", line 36 in check
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.lto/build/Lib/lib2to3/tests/test_fixers.py", line 1718 in test_import_from
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.lto/build/Lib/unittest/case.py", line 549 in _callTestMethod
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.lto/build/Lib/unittest/case.py", line 592 in run
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.lto/build/Lib/unittest/case.py", line 652 in __call__
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.lto/build/Lib/unittest/suite.py", line 122 in run
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.lto/build/Lib/unittest/suite.py", line 84 in __call__
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.lto/build/Lib/unittest/suite.py", line 122 in run
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.lto/build/Lib/unittest/suite.py", line 84 in __call__
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.lto/build/Lib/unittest/suite.py", line 122 in run
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.lto/build/Lib/unittest/suite.py", line 84 in __call__
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.lto/build/Lib/unittest/suite.py", line 122 in run
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.lto/build/Lib/unittest/suite.py", line 84 in __call__
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.lto/build/Lib/unittest/suite.py", line 122 in run
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.lto/build/Lib/unittest/suite.py", line 84 in __call__
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.lto/build/Lib/unittest/runner.py", line 176 in run
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.lto/build/Lib/test/support/__init__.py", line 959 in _run_suite
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.lto/build/Lib/test/support/__init__.py", line 1082 in run_unittest
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.lto/build/Lib/test/libregrtest/runtest.py", line 211 in _test_module
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.lto/build/Lib/test/libregrtest/runtest.py", line 236 in _runtest_inner2
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.lto/build/Lib/test/libregrtest/runtest.py", line 272 in _runtest_inner
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.lto/build/Lib/test/libregrtest/runtest.py", line 155 in _runtest
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.lto/build/Lib/test/libregrtest/runtest.py", line 195 in runtest
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.lto/build/Lib/test/libregrtest/main.py", line 319 in rerun_failed_tests
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.lto/build/Lib/test/libregrtest/main.py", line 696 in _main
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.lto/build/Lib/test/libregrtest/main.py", line 639 in main
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.lto/build/Lib/test/libregrtest/main.py", line 717 in main
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.lto/build/Lib/test/__main__.py", line 2 in <module>
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.lto/build/Lib/runpy.py", line 87 in _run_code
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.lto/build/Lib/runpy.py", line 197 in _run_module_as_main
make: *** [Makefile:1199: buildbottest] Segmentation fault (core dumped)

Cannot open file '/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.lto/build/test-results.xml' for upload

serhiy-storchaka · 2020-10-20T09:00:47Z

Lib/plistlib.py

@@ -245,7 +245,11 @@ def end_false(self):
        self.add_object(False)

    def end_integer(self):
-        self.add_object(int(self.get_data()))
+        raw = self.get_data()
+        if raw.startswith('0x') or raw.startswith('0X'):


raw.startswith(('0x', '0X'))
or
raw[:2] in ('0x', '0X')

You can also use int(raw, 0) to parse decimal and hexadecimal literals (also octal and binary).

…iles (pythonGH-22764)

bpo-41491: plistlib: accept hexadecimal integer values in xml plist f…

f703153

…iles

the-knights-who-say-ni added the CLA signed label Oct 19, 2020

bedevere-bot added the awaiting core review label Oct 19, 2020

ronaldoussoren added needs backport to 3.9 only security fixes needs backport to 3.8 and removed awaiting core review labels Oct 19, 2020

ronaldoussoren requested a review from ned-deily October 19, 2020 12:07

ronaldoussoren added the awaiting core review label Oct 19, 2020

ned-deily approved these changes Oct 19, 2020

View reviewed changes

bedevere-bot added awaiting merge and removed awaiting core review labels Oct 19, 2020

ronaldoussoren merged commit 3185267 into python:master Oct 20, 2020

bedevere-bot removed awaiting merge needs backport to 3.9 only security fixes labels Oct 20, 2020

bedevere-bot removed the needs backport to 3.8 label Oct 20, 2020

ronaldoussoren added a commit that referenced this pull request Oct 20, 2020

bpo-41491: plistlib: accept hexadecimal integer values in xml plist f…

3fc7080

…iles (GH-22764) (GH-22806) (cherry picked from commit 3185267) Co-authored-by: Ronald Oussoren <[email protected]>

serhiy-storchaka reviewed Oct 20, 2020

View reviewed changes

adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021

bpo-41491: plistlib: accept hexadecimal integer values in xml plist f…

5c46911

…iles (pythonGH-22764)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

bpo-41491: plistlib: accept hexadecimal integer values in xml plist f… #22764

bpo-41491: plistlib: accept hexadecimal integer values in xml plist f… #22764

Uh oh!

ronaldoussoren commented Oct 19, 2020 •

edited by bedevere-bot

Loading

Uh oh!

ned-deily left a comment

Uh oh!

ronaldoussoren commented Oct 20, 2020 •

edited by bedevere-bot

Loading

Uh oh!

miss-islington commented Oct 20, 2020

Uh oh!

bedevere-bot commented Oct 20, 2020

Uh oh!

bedevere-bot commented Oct 20, 2020

Uh oh!

bedevere-bot commented Oct 20, 2020

Uh oh!

bedevere-bot commented Oct 20, 2020

Uh oh!

bedevere-bot commented Oct 20, 2020

Uh oh!

serhiy-storchaka Oct 20, 2020

Uh oh!

Uh oh!

Uh oh!

bpo-41491: plistlib: accept hexadecimal integer values in xml plist f… #22764

bpo-41491: plistlib: accept hexadecimal integer values in xml plist f… #22764

Uh oh!

Conversation

ronaldoussoren commented Oct 19, 2020 • edited by bedevere-bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ned-deily left a comment

Choose a reason for hiding this comment

Uh oh!

ronaldoussoren commented Oct 20, 2020 • edited by bedevere-bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

miss-islington commented Oct 20, 2020

Uh oh!

bedevere-bot commented Oct 20, 2020

Uh oh!

bedevere-bot commented Oct 20, 2020

Uh oh!

bedevere-bot commented Oct 20, 2020

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Uh oh!

bedevere-bot commented Oct 20, 2020

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Uh oh!

bedevere-bot commented Oct 20, 2020

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Uh oh!

serhiy-storchaka Oct 20, 2020

Choose a reason for hiding this comment

Uh oh!

Uh oh!

ronaldoussoren commented Oct 19, 2020 •

edited by bedevere-bot

Loading

ronaldoussoren commented Oct 20, 2020 •

edited by bedevere-bot

Loading