Skip to content

Commit d0de86e

Browse files
committed
rename pkgpath to origin (this isn't semantically true yet)
1 parent 9b88d72 commit d0de86e

File tree

1 file changed

+10
-10
lines changed

1 file changed

+10
-10
lines changed

Python/ceval.c

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -2763,7 +2763,7 @@ PyObject *
27632763
_PyEval_ImportFrom(PyThreadState *tstate, PyObject *v, PyObject *name)
27642764
{
27652765
PyObject *x;
2766-
PyObject *fullmodname, *mod_name, *pkgpath, *mod_name_or_unknown, *errmsg;
2766+
PyObject *fullmodname, *mod_name, *origin, *mod_name_or_unknown, *errmsg;
27672767

27682768
if (PyObject_GetOptionalAttr(v, name, &x) != 0) {
27692769
return x;
@@ -2800,10 +2800,10 @@ _PyEval_ImportFrom(PyThreadState *tstate, PyObject *v, PyObject *name)
28002800
mod_name_or_unknown = mod_name;
28012801
}
28022802

2803-
pkgpath = NULL;
2803+
origin = NULL;
28042804
if (PyModule_Check(v)) {
2805-
pkgpath = PyModule_GetFilenameObject(v);
2806-
if (pkgpath == NULL) {
2805+
origin = PyModule_GetFilenameObject(v);
2806+
if (origin == NULL) {
28072807
if (!PyErr_ExceptionMatches(PyExc_SystemError)) {
28082808
Py_DECREF(mod_name_or_unknown);
28092809
return NULL;
@@ -2812,8 +2812,8 @@ _PyEval_ImportFrom(PyThreadState *tstate, PyObject *v, PyObject *name)
28122812
_PyErr_Clear(tstate);
28132813
}
28142814
}
2815-
if (pkgpath == NULL || !PyUnicode_Check(pkgpath)) {
2816-
Py_CLEAR(pkgpath);
2815+
if (origin == NULL || !PyUnicode_Check(origin)) {
2816+
Py_CLEAR(origin);
28172817
errmsg = PyUnicode_FromFormat(
28182818
"cannot import name %R from %R (unknown location)",
28192819
name, mod_name_or_unknown
@@ -2828,7 +2828,7 @@ _PyEval_ImportFrom(PyThreadState *tstate, PyObject *v, PyObject *name)
28282828
}
28292829
if (rc < 0) {
28302830
Py_DECREF(mod_name_or_unknown);
2831-
Py_DECREF(pkgpath);
2831+
Py_DECREF(origin);
28322832
return NULL;
28332833
}
28342834
const char *fmt =
@@ -2837,14 +2837,14 @@ _PyEval_ImportFrom(PyThreadState *tstate, PyObject *v, PyObject *name)
28372837
"(most likely due to a circular import) (%S)" :
28382838
"cannot import name %R from %R (%S)";
28392839

2840-
errmsg = PyUnicode_FromFormat(fmt, name, mod_name_or_unknown, pkgpath);
2840+
errmsg = PyUnicode_FromFormat(fmt, name, mod_name_or_unknown, origin);
28412841
}
28422842
/* NULL checks for errmsg and mod_name done by PyErr_SetImportError. */
2843-
_PyErr_SetImportErrorWithNameFrom(errmsg, mod_name, pkgpath, name);
2843+
_PyErr_SetImportErrorWithNameFrom(errmsg, mod_name, origin, name);
28442844

28452845
Py_XDECREF(errmsg);
28462846
Py_DECREF(mod_name_or_unknown);
2847-
Py_XDECREF(pkgpath);
2847+
Py_XDECREF(origin);
28482848
return NULL;
28492849
}
28502850

0 commit comments

Comments
 (0)