Skip to content

add tests for asyncio transport sockets #100263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Dec 28, 2022
Merged

add tests for asyncio transport sockets #100263

merged 5 commits into from
Dec 28, 2022

Conversation

kumaraditya303
Copy link
Contributor

No description provided.

@bedevere-bot bedevere-bot added awaiting core review tests Tests in the Lib/test dir labels Dec 15, 2022
@python python deleted a comment from netlify bot Dec 15, 2022
gvanrossum
gvanrossum reviewed Dec 22, 2022
View reviewed changes
Copy link
Member

@gvanrossum gvanrossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the answers to my questions are "that's just how it is for listening sockets" or something like that, why bother to verify the OS behavior?

gvanrossum
gvanrossum approved these changes Dec 27, 2022
View reviewed changes
Copy link
Member

@gvanrossum gvanrossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG, add the requested comment and land it.

@kumaraditya303 kumaraditya303 merged commit 5369bba into python:main Dec 28, 2022
@kumaraditya303 kumaraditya303 deleted the trsock branch December 28, 2022 04:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gvanrossum gvanrossum gvanrossum approved these changes

@1st1 1st1 Awaiting requested review from 1st1 1st1 is a code owner

@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner

Assignees
No one assigned
Labels
skip issue skip news tests Tests in the Lib/test dir topic-asyncio
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kumaraditya303 @gvanrossum @bedevere-bot