Skip to content

gh-100522 Add a test for 'futures.as_completed' timing out with a non-zero timeout value #100523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 26, 2023

Conversation

JosephSBoyle
Copy link
Contributor

@JosephSBoyle JosephSBoyle commented Dec 25, 2022

Resolves a longstanding TODO in the futures tests:

TODO([email protected]): Should have a test with a non-zero timeout.

by fixturizing the existing test.

@bedevere-bot bedevere-bot added awaiting review tests Tests in the Lib/test dir labels Dec 25, 2022
@JosephSBoyle JosephSBoyle changed the title gh-100552 Add a test for 'futures.as_completed' timing out with a non-zero timeout value gh-100522 Add a test for 'futures.as_completed' timing out with a non-zero timeout value Dec 25, 2022
@JosephSBoyle JosephSBoyle marked this pull request as ready for review December 25, 2022 17:11
@JosephSBoyle JosephSBoyle force-pushed the fix-issue-100522 branch 6 times, most recently from e8b4a0e to f8fdd45 Compare January 2, 2023 13:13
@kumaraditya303 kumaraditya303 requested a review from gpshead January 9, 2023 09:07
@JosephSBoyle
Copy link
Contributor Author

@gpshead bump:)

@JosephSBoyle
Copy link
Contributor Author

@gpshead bump

@AlexWaygood
Copy link
Member

Thanks for your interest in contributing, @JosephSBoyle, it's great to see :)

Unfortunately, CPython is mostly run by volunteers; very few people are paid full-time to work on CPython itself. Added to this, many CPython devs are juggling their free time between this repo and other open-source projects.

Pinging a reviewer if you haven't had a response after a few weeks is absolutely fine, but repeatedly pinging every few days isn't. Please try to be respectful of other people's time :)

@JosephSBoyle
Copy link
Contributor Author

Hi @AlexWaygood, thanks for your message. I understand what you're saying about devs being largely volunteers with other responsibilities. Apologies if I was being impolite with my bump comments, that certainly wasn't my intention.

@AlexWaygood
Copy link
Member

No worries at all @JosephSBoyle — just something to bear in mind for the future :)

@JosephSBoyle
Copy link
Contributor Author

Thank you for the review and merge @gpshead:)

mdboom pushed a commit to mdboom/cpython that referenced this pull request Jan 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants