gh-100585: Fixed a bug where importlib.resources.as_file was leaving file pointers open

[samety]

gh-100585: Fixed a bug where importlib.resources.as_file was leaving file pointers open

importlib.resources.as_file was leaving temporary file pointers open in the _write_contents function.
Fixed it by using Path.write_bytes instead of open('wb').write(...)

[FFY00]

@samety thanks for the fix! It does look correct to me.

@jaraco, we already have a fix in https://github.com/python/importlib_resources (python/importlib_resources@a4b3ef8), how do you want to handle these situations?

[jaraco]

I have plans to merge the fix from _resources to here, but I think I'd prefer to get the write_bytes technique there first. Let's do that and then I'll plan to merge them here. I'll plan to cherry-pick the change from here into importlib_resources.

[jaraco]

On further consideration, it's probably fine to merge this now. Since importlib_resources v5.10.2 applies the same change, It won't conflict when importlib_resources is merged.

[jaraco]

I looked at the failing test and it seems to be unrelated.

[miss-islington]

Thanks @samety for the PR, and @jaraco for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

[miss-islington]

Thanks @samety for the PR, and @jaraco for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

[miss-islington]

Sorry, @samety and @jaraco, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker f10f503b24a35a43910a632ee50c7568bedd6664 3.11

[miss-islington]

Sorry @samety and @jaraco, I had trouble checking out the 3.10 backport branch.
Please retry by removing and re-adding the "needs backport to 3.10" label.
Alternatively, you can backport using cherry_picker on the command line.
cherry_picker f10f503b24a35a43910a632ee50c7568bedd6664 3.10