Skip to content

Fix minor error in ePub #100614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 1, 2023
Merged

Fix minor error in ePub #100614

merged 1 commit into from
Mar 1, 2023

Conversation

methane
Copy link
Member

@methane methane commented Dec 30, 2022

Fix issue reported https://mail.python.org/archives/list/[email protected]/message/KE7OIAO53P4XRC4ZOWPDHA63ZQJCHEC3/

There are many similar errors in ePub.
But this issue is recent regression so worth enough to fix it.

@methane methane added type-bug An unexpected behavior, bug, or error docs Documentation in the Doc dir 3.11 only security fixes 3.10 only security fixes 3.12 only security fixes labels Dec 30, 2022
@methane
Copy link
Member Author

methane commented Dec 30, 2022

ogp meta tags are not needed for ePub.
For longer term, we should have separated conf and contents.rst for ePub.

Additionally, ePub is xhtml, not html. So we need to make html compatible to xhtml.

@methane methane merged commit 7d1d663 into python:main Mar 1, 2023
@methane methane deleted the fix-epub branch March 1, 2023 00:48
@methane methane added needs backport to 3.10 only security fixes needs backport to 3.11 only security fixes labels Mar 1, 2023
@miss-islington
Copy link
Contributor

Thanks @methane for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Thanks @methane for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry, @methane, I could not cleanly backport this to 3.10 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 7d1d66341838d7d1963c9ee7ffca2950d3a751fd 3.10

@miss-islington
Copy link
Contributor

Sorry @methane, I had trouble checking out the 3.11 backport branch.
Please retry by removing and re-adding the "needs backport to 3.11" label.
Alternatively, you can backport using cherry_picker on the command line.
cherry_picker 7d1d66341838d7d1963c9ee7ffca2950d3a751fd 3.11

@bedevere-bot
Copy link

GH-102348 is a backport of this pull request to the 3.11 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Mar 1, 2023
methane added a commit to methane/cpython that referenced this pull request Mar 1, 2023
@methane
[3.11] Doc: Fix minor error in ePub (pythonGH-100614)
b1a8241 
Fix issue reported https://mail.python.org/archives/list/[email protected]/message/KE7OIAO53P4XRC4ZOWPDHA63ZQJCHEC3/
(cherry picked from commit 7d1d663)

Co-authored-by: Inada Naoki <[email protected]>
methane added a commit that referenced this pull request Mar 1, 2023
@methane
Doc: Fix minor error in ePub (GH-100614)
90ec292 
Fix issue reported https://mail.python.org/archives/list/[email protected]/message/KE7OIAO53P4XRC4ZOWPDHA63ZQJCHEC3/
(cherry picked from commit 7d1d663)
@methane methane removed needs backport to 3.10 only security fixes 3.10 only security fixes labels Mar 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@methane methane

Labels
3.11 only security fixes 3.12 only security fixes docs Documentation in the Doc dir skip issue skip news type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@methane @miss-islington @bedevere-bot