Docs: fix ssizeobjargproc parameters #100736
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The type `ssizeobjargproc` was missing the last `PyObject *` parameter. The actual type is defined at [1] and has the signature: `typedef int(*ssizeobjargproc)(PyObject *, Py_ssize_t, PyObject *);` [1]: https://github.com/python/cpython/blob/a286caa937405f7415dcc095a7ad5097c4433246/Include/object.h#L205
|
All commit authors signed the Contributor License Agreement. |
kumaraditya303
added
skip issue
needs backport to 3.10
|
Thanks @dlech for the PR, and @kumaraditya303 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jan 4, 2023
(cherry picked from commit 5fb1c08) Co-authored-by: David Lechner <[email protected]>
|
GH-100743 is a backport of this pull request to the 3.11 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jan 4, 2023
(cherry picked from commit 5fb1c08) Co-authored-by: David Lechner <[email protected]>
|
GH-100744 is a backport of this pull request to the 3.10 branch. |
miss-islington
added a commit
that referenced
this pull request
Jan 4, 2023
(cherry picked from commit 5fb1c08) Co-authored-by: David Lechner <[email protected]>
miss-islington
added a commit
that referenced
this pull request
Jan 4, 2023
(cherry picked from commit 5fb1c08) Co-authored-by: David Lechner <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The type
ssizeobjargprocwas missing the lastPyObject *parameter. The actual type is defined at 1 and has the signature:typedef int(*ssizeobjargproc)(PyObject *, Py_ssize_t, PyObject *);