Skip to content

gh-100776: Fix misleading default value in help(input) #100788

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 8, 2023
Merged

gh-100776: Fix misleading default value in help(input) #100788

merged 2 commits into from
Jan 8, 2023

Conversation

hauntsaninja
Copy link
Contributor

@hauntsaninja hauntsaninja commented Jan 6, 2023 •
edited by bedevere-bot
Loading

@bedevere-bot bedevere-bot mentioned this pull request Jan 6, 2023
Closed
@hauntsaninja hauntsaninja changed the title gh-100776: Make input's __text_signature__ less misleading gh-100776: Make help(input) less misleading Jan 6, 2023
@hauntsaninja hauntsaninja changed the title gh-100776: Make help(input) less misleading gh-100776: Fix misleading default value in help(input) Jan 6, 2023
sobolevn
sobolevn approved these changes Jan 6, 2023
View reviewed changes
Copy link
Member

@sobolevn sobolevn left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! input() does the same thing as input("") (the new default).

@hauntsaninja
Copy link
Contributor Author

hauntsaninja commented Jan 6, 2023 •
edited
Loading

Note that this doesn't actually change the behaviour of input, just the docstring. Either way, the actual default is NULL :-)

@kumaraditya303 kumaraditya303 merged commit a214188 into python:main Jan 8, 2023
@hauntsaninja hauntsaninja deleted the gh-100776 branch January 8, 2023 08:29
@hauntsaninja hauntsaninja added needs backport to 3.10 only security fixes needs backport to 3.11 only security fixes labels Jan 8, 2023
@miss-islington
Copy link
Contributor

Thanks @hauntsaninja for the PR, and @kumaraditya303 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Thanks @hauntsaninja for the PR, and @kumaraditya303 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry, @hauntsaninja and @kumaraditya303, I could not cleanly backport this to 3.10 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker a2141882f259e21bb09fa0b7cba8142147b9e3d7 3.10

@miss-islington
Copy link
Contributor

Sorry @hauntsaninja and @kumaraditya303, I had trouble checking out the 3.11 backport branch.
Please retry by removing and re-adding the "needs backport to 3.11" label.
Alternatively, you can backport using cherry_picker on the command line.
cherry_picker a2141882f259e21bb09fa0b7cba8142147b9e3d7 3.11

@bedevere-bot
Copy link

GH-100841 is a backport of this pull request to the 3.11 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Jan 8, 2023
@hauntsaninja
Copy link
Contributor Author

I can do the backports

hauntsaninja added a commit to hauntsaninja/cpython that referenced this pull request Jan 8, 2023
@hauntsaninja
[3.11] pythongh-100776: Fix misleading default value in help(input) (p…
73e247f 
…ythonGH-100788).

(cherry picked from commit a214188)

Co-authored-by: Shantanu <[email protected]>
@bedevere-bot
Copy link

GH-100842 is a backport of this pull request to the 3.10 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Jan 8, 2023
hauntsaninja added a commit to hauntsaninja/cpython that referenced this pull request Jan 8, 2023
@hauntsaninja
[3.10] pythongh-100776: Fix misleading default value in help(input) (p…
685bc1c 
…ythonGH-100788).

(cherry picked from commit a214188)

Co-authored-by: Shantanu <[email protected]>
hauntsaninja added a commit that referenced this pull request Jan 8, 2023
@hauntsaninja
[3.11] gh-100776: Fix misleading default value in help(input) (GH-100788
be7c197 
) (#100841)

(cherry picked from commit a214188)

Co-authored-by: Shantanu <[email protected]>
hauntsaninja added a commit that referenced this pull request Jan 8, 2023
@hauntsaninja
[3.10] gh-100776: Fix misleading default value in help(input) (GH-100788
a8702bb 
) (#100842)

(cherry picked from commit a214188)

Co-authored-by: Shantanu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sobolevn sobolevn sobolevn approved these changes

@kumaraditya303 kumaraditya303 kumaraditya303 approved these changes

Assignees

@kumaraditya303 kumaraditya303

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@hauntsaninja @miss-islington @bedevere-bot @sobolevn @kumaraditya303