Skip to content

GH-101111: Disambigaute origin of const for store_const and append_const #101121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

jugmac00
Copy link
Contributor

@jugmac00 jugmac00 commented Jan 18, 2023

While the documentation for optparse mentioned that both store_const and append_const store a constant value, it was not clear where this value was coming from.

A link to Option.const makes this explicit.

…end_const

While the documentation for `optparse` mentioned that both `store_const` and
`append_const` store a constant value, it was not clear where this value was
coming from.

A link to `Option.const` makes this explicit.
@jugmac00
Copy link
Contributor Author

jugmac00 commented Jan 18, 2023

I had a look at some other documentation pull requests, and it looks like there is no need to create a news snippet via blurb.it. Please tell if otherwise.

@ambv ambv added needs backport to 3.10 only security fixes needs backport to 3.11 only security fixes labels Jan 20, 2023
@ambv ambv merged commit 9a15513 into python:main Jan 20, 2023
@miss-islington
Copy link
Contributor

Thanks @jugmac00 for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 20, 2023
…end_const (pythonGH-101121)

While the documentation for `optparse` mentioned that both `store_const` and
`append_const` store a constant value, it was not clear where this value was
coming from.

A link to `Option.const` makes this explicit.
(cherry picked from commit 9a15513)

Co-authored-by: Jürgen Gmach <[email protected]>
@bedevere-bot
Copy link

GH-101203 is a backport of this pull request to the 3.11 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Jan 20, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 20, 2023
…end_const (pythonGH-101121)

While the documentation for `optparse` mentioned that both `store_const` and
`append_const` store a constant value, it was not clear where this value was
coming from.

A link to `Option.const` makes this explicit.
(cherry picked from commit 9a15513)

Co-authored-by: Jürgen Gmach <[email protected]>
@bedevere-bot
Copy link

GH-101204 is a backport of this pull request to the 3.10 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Jan 20, 2023
ambv pushed a commit that referenced this pull request Jan 20, 2023
…pend_const (GH-101121) (#101203)

(cherry picked from commit 9a15513)

While the documentation for `optparse` mentioned that both `store_const` and
`append_const` store a constant value, it was not clear where this value was
coming from.

A link to `Option.const` makes this explicit.

Co-authored-by: Jürgen Gmach <[email protected]>
ambv pushed a commit that referenced this pull request Jan 20, 2023
…pend_const (GH-101121) (#101204)

(cherry picked from commit 9a15513)

While the documentation for `optparse` mentioned that both `store_const` and
`append_const` store a constant value, it was not clear where this value was
coming from.

A link to `Option.const` makes this explicit.

Co-authored-by: Jürgen Gmach <[email protected]>
@jugmac00 jugmac00 deleted the disambiguate-usage-of-store_const-and-append_const branch March 12, 2023 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants