Skip to content

bpo-34160: Preserve user specified order of Element attributes in html. #10190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 29, 2018
Merged

bpo-34160: Preserve user specified order of Element attributes in html. #10190

merged 1 commit into from
Oct 29, 2018

Conversation

serhiy-storchaka
Copy link
Member

@serhiy-storchaka serhiy-storchaka commented Oct 28, 2018 •
edited by bedevere-bot
Loading

@serhiy-storchaka serhiy-storchaka added type-feature A feature request or enhancement skip news labels Oct 28, 2018
vstinner
vstinner reviewed Oct 28, 2018
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change deserves a NEWS entry, no?

@serhiy-storchaka
Copy link
Member Author

This is just a follow up of #10163. It doesn't need additional documenting.

vstinner
vstinner approved these changes Oct 29, 2018
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@vstinner
Copy link
Member

This is just a follow up of #10163. It doesn't need additional documenting.

I checked, ok, I agree.

@serhiy-storchaka serhiy-storchaka merged commit 3b05ad7 into python:master Oct 29, 2018
@serhiy-storchaka serhiy-storchaka deleted the etree-attrs-order-html branch October 29, 2018 17:31
@vstinner vstinner mentioned this pull request Oct 29, 2018
Merged
@koubaa koubaa mentioned this pull request Apr 19, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vstinner vstinner vstinner approved these changes

@rhettinger rhettinger Awaiting requested review from rhettinger

Assignees
No one assigned
Labels
skip news type-feature A feature request or enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@serhiy-storchaka @vstinner @the-knights-who-say-ni @bedevere-bot