-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
gh-72249: Include the module name in the repr of partial object #101910
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
ce00bbd
Include the module name in the repr of functool
furkanonder 313f4a2
📜🤖 Added by blurb_it.
blurb-it[bot] 0457cc7
Merge branch 'main' into issue-72249
furkanonder a224851
Mention the authors
furkanonder 6c98069
Merge branch 'main' into issue-72249
furkanonder dbd79c9
Merge branch 'main' into issue-72249
furkanonder 4551a42
update the news entry
furkanonder aacf90d
remove _partial_types check in testcases
furkanonder 902e690
use PyType_GetQualName and _PyType_GetModuleName functions to match t…
furkanonder 930928e
Merge branch 'main' into issue-72249
furkanonder 810b5ca
Check return value of _PyType_GetModuleName
furkanonder f79ce5e
Merge branch 'main' into issue-72249
furkanonder 3777e81
reduce the type(self) usage in __repr__
furkanonder 5369fad
Don't handle the partial's repr without __module__
furkanonder ef9ea5c
Merge branch 'issue-72249' of github.com:furkanonder/cpython into iss…
furkanonder 52390d3
call Py_ReprLeave
furkanonder e2174aa
Remove else clause
furkanonder 4542342
Use %S as conversion specifier for module
furkanonder File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 2 additions & 0 deletions
2
Misc/NEWS.d/next/Library/2023-02-14-17-19-59.gh-issue-72249.fv35wU.rst
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
:func:`functools.partial`s of :func:`repr` has been improved to include the | ||
:term:`module` name. Patched by Furkan Onder and Anilyka Barry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.