bpo-35147: Fix _Py_NO_RETURN for GCC #10300
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use __GNUC__ instead of non-existing __GNUC_MAJOR__.
serhiy-storchaka
approved these changes
Nov 2, 2018
serhiy-storchaka
added
type-bug
|
@izbyshev: Status check is done, and it's a success ✅ . |
|
Thanks @izbyshev for the PR 🌮🎉.. I'm working now to backport this PR to: 3.6, 3.7. |
|
Sorry, @izbyshev, I could not cleanly backport this to |
|
Sorry, @izbyshev, I could not cleanly backport this to |
izbyshev
pushed a commit
to izbyshev/cpython
that referenced
this pull request
Nov 2, 2018
Use `__GNUC__` instead of non-existing `__GNUC_MAJOR__`. https://bugs.python.org/issue35147. (cherry picked from commit e2ed5ad) Co-authored-by: Alexey Izbyshev <[email protected]>
|
GH-10301 is a backport of this pull request to the 3.7 branch. |
izbyshev
pushed a commit
to izbyshev/cpython
that referenced
this pull request
Nov 2, 2018
Use `__GNUC__` instead of non-existing `__GNUC_MAJOR__`. https://bugs.python.org/issue35147. (cherry picked from commit e2ed5ad) Co-authored-by: Alexey Izbyshev <[email protected]>
|
GH-10302 is a backport of this pull request to the 3.6 branch. |
miss-islington
pushed a commit
that referenced
this pull request
Nov 3, 2018
Use `__GNUC__` instead of non-existing `__GNUC_MAJOR__`. (cherry picked from commit e2ed5ad) https://bugs.python.org/issue35147
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
__GNUC__instead of non-existing__GNUC_MAJOR__.https://bugs.python.org/issue35147