Skip to content

[2.7] Docs: fix some wrong words (GH-6987) #10315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 4, 2018

Conversation

matrixise
Copy link
Member

Fix typos in code comments: bdb.py and configure.ac..
(cherry picked from commit b5c246f)

Co-authored-by: Eitan Adler [email protected]
Co-authored-by: Stéphane Wirtel [email protected]

Fix typos in code comments: bdb.py and configure.ac..
(cherry picked from commit b5c246f)

Co-authored-by: Eitan Adler [email protected]
Co-authored-by: Stéphane Wirtel <[email protected]>
@matrixise
Copy link
Member Author

@Mariatta and @ned-deily I have backported the PR #7572 in this PR, and just used the content of configure.ac

I have not changed the content of configure because this one could be updated with autoconf or autoreconf but the diff is bigger.

@matrixise
Copy link
Member Author

I have updated the configure and aclocal.m4 files with autoreconf (from autoconf 2.65) like described in this paragraph: https://devguide.python.org/setup/#regenerate-configure

Copy link
Member

@ned-deily ned-deily left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While it's important to keep configure.ac and configure in sync, you need to use an up-to-date version of autoconf: note the version you used is older than the one previously used and therefore is causing a lot of unnecessary changes and reverts. Suggest you revert that most recent commit and add a new one that simply makes the one-line change to the comment by hand. Also, note that the PR commit message is not accurate in that it refers to changes to bdb.py that were not necessary for 2.7.

@bedevere-bot
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@matrixise
Copy link
Member Author

Hi @ned-deily

In fact, I used an older version of autoconf because I have read this paragraph from the devguide

Python’s configure.ac script typically requires a specific version of Autoconf. At the moment, this reads: AC_PREREQ(2.65).
If the system copy of Autoconf does not match this version, you will need to install your own copy of Autoconf.

but ok, I am going to update this PR with the last version of autoconf on my fedora 28.

@matrixise
Copy link
Member Author

Updated with autoconf 2.69, but maybe we should update the doc and indicate "You have to use a version at least equal to the required version in the configure.ac file"

@ned-deily
Copy link
Member

ned-deily commented Nov 4, 2018

@matrixise Thanks for the reminder about the devguide. It appears that the autotools version was recently bumped for master but not for the other branches even though their configure files were all generated with 2.69 :) I reopened bpo-33486 about it.

@matrixise
Copy link
Member Author

Thanks for bpo-33486.

What's the next step(s) for the approval of this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants