-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
[2.7] Docs: fix some wrong words (GH-6987) #10315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Fix typos in code comments: bdb.py and configure.ac.. (cherry picked from commit b5c246f) Co-authored-by: Eitan Adler [email protected] Co-authored-by: Stéphane Wirtel <[email protected]>
@Mariatta and @ned-deily I have backported the PR #7572 in this PR, and just used the content of I have not changed the content of |
I have updated the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While it's important to keep configure.ac and configure in sync, you need to use an up-to-date version of autoconf: note the version you used is older than the one previously used and therefore is causing a lot of unnecessary changes and reverts. Suggest you revert that most recent commit and add a new one that simply makes the one-line change to the comment by hand. Also, note that the PR commit message is not accurate in that it refers to changes to bdb.py that were not necessary for 2.7.
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
Hi @ned-deily In fact, I used an older version of autoconf because I have read this paragraph from the devguide
but ok, I am going to update this PR with the last version of autoconf on my fedora 28. |
Updated with autoconf 2.69, but maybe we should update the doc and indicate "You have to use a version at least equal to the required version in the |
@matrixise Thanks for the reminder about the devguide. It appears that the autotools version was recently bumped for master but not for the other branches even though their configure files were all generated with 2.69 :) I reopened bpo-33486 about it. |
Thanks for bpo-33486. What's the next step(s) for the approval of this PR? |
Fix typos in code comments: bdb.py and configure.ac..
(cherry picked from commit b5c246f)
Co-authored-by: Eitan Adler [email protected]
Co-authored-by: Stéphane Wirtel [email protected]