Skip to content

bpo-32409: Revert "bpo-32409: Fix regression in activate.bat on international Windows (GH-10295)" #10403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 7, 2018
Merged

bpo-32409: Revert "bpo-32409: Fix regression in activate.bat on international Windows (GH-10295)" #10403

merged 1 commit into from
Nov 7, 2018

Conversation

pablogsal
Copy link
Member

@pablogsal pablogsal commented Nov 7, 2018 •
edited
Loading

@pablogsal
Copy link
Member Author

CC @samstagern @eryksun @vsajip

@pablogsal pablogsal requested review from vstinner and vsajip November 7, 2018 23:01
vstinner
vstinner approved these changes Nov 7, 2018
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'm always in favor of reverting changes which break the CI :-)

@vstinner
Copy link
Member

vstinner commented Nov 7, 2018

If your buildbot-custom branch change is this PR, it failed on: https://buildbot.python.org/all/#builders/42/builds/5

@pablogsal pablogsal merged commit 6843ffe into python:master Nov 7, 2018
@miss-islington
Copy link
Contributor

Thanks @pablogsal for the PR 🌮🎉.. I'm working now to backport this PR to: 3.6, 3.7.
🐍🍒⛏🤖

@pablogsal pablogsal deleted the revert-9b6adac branch November 7, 2018 23:55
@bedevere-bot
Copy link

GH-10405 is a backport of this pull request to the 3.7 branch.

@miss-islington
Copy link
Contributor

Sorry, @pablogsal, I could not cleanly backport this to 3.6 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 6843ffe4533e9f2cde036296fd932fef6f059687 3.6

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 7, 2018
@pablogsal @miss-islington
Revert "bpo-32409: Fix regression in activate.bat on international Wi…
b655bbb 
…ndows (pythonGH-10295)" (pythonGH-10403)

This reverts commit c64583b due to multiple buildbot failures when building it.
(cherry picked from commit 6843ffe)

Co-authored-by: Pablo Galindo <[email protected]>
@pablogsal
Copy link
Member Author

pablogsal commented Nov 7, 2018 •
edited
Loading

@vstinner

If your buildbot-custom branch change is this PR, it failed on: https://buildbot.python.org/all/#builders/42/builds/5

No, that is basically the same error that this PR is fixing but with extra printing to see what exactly was failing in the original PR. Check the diff here:

67ef3de

@pablogsal
Copy link
Member Author

The commit was not backported to 3.6, so is no need to backport this to 3.6. :)

Good job @miss-islington !

miss-islington added a commit that referenced this pull request Nov 8, 2018
@miss-islington @pablogsal
Revert "bpo-32409: Fix regression in activate.bat on international Wi…
3ba5e25 
…ndows (GH-10295)" (GH-10403)

This reverts commit c64583b due to multiple buildbot failures when building it.
(cherry picked from commit 6843ffe)

Co-authored-by: Pablo Galindo <[email protected]>
@pablogsal pablogsal mentioned this pull request Nov 8, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vstinner vstinner vstinner approved these changes

@vsajip vsajip Awaiting requested review from vsajip

Assignees

@pablogsal pablogsal

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@pablogsal @vstinner @miss-islington @bedevere-bot @the-knights-who-say-ni