bpo-30017: Allowed calling the close() method of the zip entry writer object #1041
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… object multiple times. Writing to closed zip entry writer object now always produce a ValueError.
serhiy-storchaka
added
type-bug
|
@serhiy-storchaka, thanks for your PR! By analyzing the history of the files in this pull request, we identified @ezio-melotti, @loewis and @Yhg1s to be potential reviewers. |
vadmium
reviewed
Apr 9, 2017
Misc/NEWS
Outdated
| @@ -303,6 +303,10 @@ Extension Modules | |||
| Library | |||
| ------- | |||
|
|
|||
| - bpo-30017: Allowed calling the close() method of the zip entry writer object | |||
| multiple times. Writing to closed zip entry writer object now always produce | |||
| a ValueError. | |||
There was a problem hiding this comment.
Needs singular form of “produces”. I would put “Writing to a closed writer now always produces a ValueError.”
There was a problem hiding this comment.
Done. Thank you.
serhiy-storchaka
added a commit
to serhiy-storchaka/cpython
that referenced
this pull request
Apr 12, 2017
… object (python#1041) multiple times. Writing to closed zip entry writer object now always produce a ValueError. (cherry picked from commit 4c0d9ea)
serhiy-storchaka
added a commit
that referenced
this pull request
Apr 16, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
multiple times. Writing to closed zip entry writer object now always produce
a ValueError.