Skip to content

gh-104089: catch DeprecationWarning in test_fstring #104137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
May 4, 2023
Merged

gh-104089: catch DeprecationWarning in test_fstring #104137

merged 5 commits into from
May 4, 2023

Conversation

sunmy2019
Copy link
Member

@sunmy2019 sunmy2019 commented May 3, 2023 •
edited by serhiy-storchaka
Loading

@bedevere-bot bedevere-bot mentioned this pull request May 3, 2023
Closed
@bedevere-bot bedevere-bot added tests Tests in the Lib/test dir awaiting review labels May 3, 2023
@sunmy2019
Copy link
Member Author

I think news may be skipped for this PR.

Eclips4
Eclips4 reviewed May 3, 2023
View reviewed changes
AlexWaygood
AlexWaygood reviewed May 3, 2023
View reviewed changes
AlexWaygood
AlexWaygood reviewed May 4, 2023
View reviewed changes
AlexWaygood
AlexWaygood approved these changes May 4, 2023
View reviewed changes
Copy link
Member

@AlexWaygood AlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AlexWaygood AlexWaygood self-assigned this May 4, 2023
@AlexWaygood AlexWaygood merged commit 83751bb into python:main May 4, 2023
@sunmy2019 sunmy2019 deleted the gh-104089 branch May 4, 2023 11:29
@serhiy-storchaka serhiy-storchaka mentioned this pull request Feb 2, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Eclips4 Eclips4 Eclips4 left review comments

@AlexWaygood AlexWaygood AlexWaygood approved these changes

Assignees

@AlexWaygood AlexWaygood

Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Failed test_write_filtered_python_package test case in ./python -We -m test -v test_zipfile
5 participants
@sunmy2019 @AlexWaygood @Eclips4 @arhadthedev @bedevere-bot