Test specialization's thread-safety #105953
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markshannon
approved these changes
Jun 22, 2023
Lib/test/test_opcache.py
Outdated
| class TestRacesDoNotCrash(unittest.TestCase): | ||
| # Careful with these. Bigger numbers have a higher chance of catching bugs, | ||
| # but you can also burn through a *ton* of type/dict/function versions: | ||
| ITEMS = 1 << 10 |
There was a problem hiding this comment.
Any reason why these need to be powers of 2? If not, maybe use 1000 instead.
There was a problem hiding this comment.
It was useful when I was trying to dial in a good value while being aware of exactly how many versions I was using. I can change them, though.
| # Run: | ||
| for writer in writers: | ||
| writer.start() | ||
| read(items) # BOOM! |
There was a problem hiding this comment.
Would increasing the number of reader threads allow us to burn through fewer versions by increasing the chance of failure per version change?
There was a problem hiding this comment.
I didn't see a significant impact on crashiness when dialing the thread count up to moderate levels, and beyond that it just took forever to run.
hoodmane
added a commit
to hoodmane/cpython
that referenced
this pull request
Jun 28, 2023
This skips the test added in python#105953 for threadless builds This fixes the wasm buildbots
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.