Skip to content

gh-107226: PyModule_AddObjectRef() should only be in the limited API 3.10 #107227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

serhiy-storchaka
Copy link
Member

@serhiy-storchaka serhiy-storchaka commented Jul 25, 2023

@serhiy-storchaka serhiy-storchaka force-pushed the limited-capi-PyModule_AddObjectRef branch from a7d7a47 to 333c910 Compare July 25, 2023 10:45
@vstinner vstinner removed the needs backport to 3.10 only security fixes label Jul 25, 2023
@vstinner
Copy link
Member

You should not backport this change to Python 3.10:

Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@miss-islington
Copy link
Contributor

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

@serhiy-storchaka serhiy-storchaka deleted the limited-capi-PyModule_AddObjectRef branch July 25, 2023 19:01
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 25, 2023
…d API 3.10 (pythonGH-107227)

(cherry picked from commit 698b015)

Co-authored-by: Serhiy Storchaka <[email protected]>
@bedevere-bot
Copy link

GH-107260 is a backport of this pull request to the 3.12 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.12 only security fixes label Jul 25, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 25, 2023
…d API 3.10 (pythonGH-107227)

(cherry picked from commit 698b015)

Co-authored-by: Serhiy Storchaka <[email protected]>
@bedevere-bot
Copy link

GH-107261 is a backport of this pull request to the 3.11 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Jul 25, 2023
serhiy-storchaka added a commit that referenced this pull request Jul 25, 2023
…ed API 3.10 (GH-107227) (GH-107260)

(cherry picked from commit 698b015)

Co-authored-by: Serhiy Storchaka <[email protected]>
serhiy-storchaka added a commit that referenced this pull request Jul 25, 2023
…ed API 3.10 (GH-107227) (GH-107261)

(cherry picked from commit 698b015)

Co-authored-by: Serhiy Storchaka <[email protected]>
jtcave pushed a commit to jtcave/cpython that referenced this pull request Jul 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants