Attempt to speed up deepfreeze.py #107887
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of calling get_identifiers_and_strings(), extract identifiers and strings from pycore_global_strings.h.
|
Not much of a difference on my machine, it goes from 2.4 sec to 2 sec but speedup seems worth it for Mac. |
kumaraditya303
approved these changes
Aug 12, 2023
Eclips4
added
performance
|
I'd like to merge this some time Monday. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
get_identifiers_and_strings(), extract identifiers and strings from pycore_global_strings.h.ast.literal_eval(), which speeds updecode_frozen_data()tremendously.On my Mac, the first commit cuts the time to run deepfreeze.py in half, from 9 to 4.5 seconds, and the second and third commits cut more than halve it again, to 1.8 seconds.
I verified that the output is the same.