gh-107619: Extend functools LRU cache docs with generators and async functions #107934
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All commit authors signed the Contributor License Agreement. |
Closed
2 tasks
rhettinger
approved these changes
Aug 14, 2023
AA-Turner
changed the title
AA-Turner
added
needs backport to 3.11
AA-Turner
reviewed
Aug 14, 2023
Co-authored-by: Adam Turner <[email protected]>
|
Accepted the suggested changes. |
AA-Turner
reviewed
Aug 14, 2023
Co-authored-by: Adam Turner <[email protected]>
|
Oh yes, you are right, I have added what you said. |
AA-Turner
approved these changes
Aug 14, 2023
Hels15
requested review from
1st1,
asvetlov,
gvanrossum,
kumaraditya303 and
willingc
as code owners
kumaraditya303
approved these changes
Aug 20, 2023
|
Thanks @Hels15 for the PR, and @kumaraditya303 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Aug 20, 2023
…async functions (pythonGH-107934) (cherry picked from commit 1a713ea) Co-authored-by: Hadházy Tamás <[email protected]> Co-authored-by: Adam Turner <[email protected]> Co-authored-by: Kumar Aditya <[email protected]>
|
GH-108161 is a backport of this pull request to the 3.12 branch. |
|
GH-108162 is a backport of this pull request to the 3.11 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Aug 20, 2023
…async functions (pythonGH-107934) (cherry picked from commit 1a713ea) Co-authored-by: Hadházy Tamás <[email protected]> Co-authored-by: Adam Turner <[email protected]> Co-authored-by: Kumar Aditya <[email protected]>
kumaraditya303
added a commit
that referenced
this pull request
Aug 20, 2023
… async functions (GH-107934) (#108162) gh-107619: Extend functools LRU cache docs with generators and async functions (GH-107934) (cherry picked from commit 1a713ea) Co-authored-by: Hadházy Tamás <[email protected]> Co-authored-by: Adam Turner <[email protected]> Co-authored-by: Kumar Aditya <[email protected]>
Yhg1s
pushed a commit
that referenced
this pull request
Aug 20, 2023
… async functions (GH-107934) (#108161) gh-107619: Extend functools LRU cache docs with generators and async functions (GH-107934) (cherry picked from commit 1a713ea) Co-authored-by: Hadházy Tamás <[email protected]> Co-authored-by: Adam Turner <[email protected]> Co-authored-by: Kumar Aditya <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extend
functools LRU cachedocs withgenerators and async functions. An async functionreturns a coroutine, not the actual function result. That means that the cache decorator is caching the coroutine, not the function result. Since the coroutine is not "reawaitable", we get an exception. This princludes generators and async functions in the list of places where it doesn't cache doesn't make sense.asyncio.as_completedversusasyncio.gather()#107619📚 Documentation preview 📚: https://cpython-previews--107934.org.readthedocs.build/