gh-108465: Use compiler basename when determining compiler flags #108392
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NOTE: Since my name is "jmicco" I cannot successfully build python using gcc in my home directory because incorrect options were added to the compiler command line because the path to gcc contained icc
|
All commit authors signed the Contributor License Agreement. |
|
Most changes to Python require a NEWS entry. Please add it using the blurb_it web app or the blurb command-line tool. |
corona10
changed the title
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
AA-Turner
changed the title
erlend-aasland
changed the title
2 tasks
2 tasks
GNU Autoconf discourages the use of basename, and recommends expr instead
erlend-aasland
added
the
🔨 test-with-buildbots
This comment was marked as outdated.
This comment was marked as outdated.
bedevere-bot
removed
the
🔨 test-with-buildbots
|
Hm, the buildbot run didn't trigger; is Bedevere out of service? |
erlend-aasland
added
the
🔨 test-with-buildbots
This comment was marked as outdated.
This comment was marked as outdated.
bedevere-bot
removed
the
🔨 test-with-buildbots
|
Erland - Thank you so much for taking this on. I am no longer the only person in my group who cannot build Python! Is there anything more needed from me? |
erlend-aasland
added
the
🔨 test-with-buildbots
This comment was marked as outdated.
This comment was marked as outdated.
bedevere-bot
removed
the
🔨 test-with-buildbots
No, you're fine; I'm going to land this later today :) Note that this is not suitable for backporting, IMO. |
|
Thanks for the patch, @jmicco! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: Since my name is "jmicco" I cannot successfully build python using gcc in my home directory because incorrect options were added to the compiler command line because the path to gcc contained icc
I did not have an issue for this - but it blocked me from building python and was not easy to find.