Fix iter_index() to work with lists which do not support stop=None. #109306
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add tests for NaN searches.
rhettinger
added
type-bug
|
Thanks @rhettinger for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Sep 12, 2023
…ythongh-109306) (cherry picked from commit f2a55fe) Co-authored-by: Raymond Hettinger <[email protected]>
|
GH-109310 is a backport of this pull request to the 3.12 branch. |
Comment on lines
+1356
to
+1358
| >>> # Test list input. Lists do not support None for the stop argument | ||
| >>> list(iter_index(list('AABCADEAF'), 'A')) | ||
| [0, 1, 4, 7] |
There was a problem hiding this comment.
Was not list input already tested above, in list(iter_index([0, x, x, y, 0], x))?
If you want a separate test for list which does not involve NaN, it is better to move this test upper, just after list(iter_index(iter('AABCADEAF'), 'A', 1, 7)).
Yhg1s
pushed a commit
that referenced
this pull request
Sep 12, 2023
…None. (gh-109306) (#109310) Fix iter_index() to work with lists which do not support stop=None. (gh-109306) (cherry picked from commit f2a55fe) Co-authored-by: Raymond Hettinger <[email protected]>
vstinner
pushed a commit
to vstinner/cpython
that referenced
this pull request
Sep 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
iter_index()did not work for list inputs.📚 Documentation preview 📚: https://cpython-previews--109306.org.readthedocs.build/