-
-
Notifications
You must be signed in to change notification settings - Fork 32.2k
regrtest: Prepend 'use' options in --{fast,slow}-ci #110363
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This allows individual resources to be disabled without having to explicitly re-enable all others.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add more tests to test_regrtest.test_use() when -u option is specified more than once.
This change allows to only enable/disable some resources, without having to override all resources set previously be a previous -u, --fast-ci or --slow-ci option. I think that it's a reasonable choice.
For example, --slow-ci -u-gui
run tests with -u all,-gui
. Previously, tests were run with... no resource enabled at all. I just saw that some buildbots use something like --slow-ci -u-cpu
and now all resources are disabled.
@serhiy-storchaka: Are you fine with the new behavior?
This allows individual resources to be disabled without having to explicitly re-enable all others. (cherry picked from commit b75186f) Co-authored-by: Zachary Ware <[email protected]>
This allows individual resources to be disabled without having to explicitly re-enable all others. (cherry picked from commit b75186f) Co-authored-by: Zachary Ware <[email protected]>
GH-110924 is a backport of this pull request to the 3.11 branch. |
GH-110925 is a backport of this pull request to the 3.12 branch. |
Please backport libregrtest changes to 3.11 and 3.12 branches. I just did it. |
#110925) regrtest: Prepend 'use' options in --{fast,slow}-ci (GH-110363) This allows individual resources to be disabled without having to explicitly re-enable all others. (cherry picked from commit b75186f) Co-authored-by: Zachary Ware <[email protected]>
#110924) regrtest: Prepend 'use' options in --{fast,slow}-ci (GH-110363) This allows individual resources to be disabled without having to explicitly re-enable all others. (cherry picked from commit b75186f) Co-authored-by: Zachary Ware <[email protected]>
This allows individual resources to be disabled without having to explicitly re-enable all others.
This allows individual resources to be disabled without having to explicitly re-enable all others.
This allows individual resources to be disabled without having to
explicitly re-enable all others.