Skip to content

regrtest: Prepend 'use' options in --{fast,slow}-ci #110363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 15, 2023

Conversation

zware
Copy link
Member

@zware zware commented Oct 4, 2023

This allows individual resources to be disabled without having to
explicitly re-enable all others.

This allows individual resources to be disabled without having to
explicitly re-enable all others.
@zware zware added tests Tests in the Lib/test dir skip issue skip news labels Oct 4, 2023
@zware zware requested a review from vstinner October 4, 2023 15:02
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add more tests to test_regrtest.test_use() when -u option is specified more than once.

This change allows to only enable/disable some resources, without having to override all resources set previously be a previous -u, --fast-ci or --slow-ci option. I think that it's a reasonable choice.

For example, --slow-ci -u-gui run tests with -u all,-gui. Previously, tests were run with... no resource enabled at all. I just saw that some buildbots use something like --slow-ci -u-cpu and now all resources are disabled.

@serhiy-storchaka: Are you fine with the new behavior?

@ambv ambv merged commit b75186f into python:main Oct 15, 2023
@vstinner vstinner added needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels Oct 16, 2023
@miss-islington
Copy link
Contributor

Thanks @zware for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@miss-islington
Copy link
Contributor

Thanks @zware for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 16, 2023
This allows individual resources to be disabled without having to explicitly re-enable all others.
(cherry picked from commit b75186f)

Co-authored-by: Zachary Ware <[email protected]>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 16, 2023
This allows individual resources to be disabled without having to explicitly re-enable all others.
(cherry picked from commit b75186f)

Co-authored-by: Zachary Ware <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Oct 16, 2023

GH-110924 is a backport of this pull request to the 3.11 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.11 only security fixes label Oct 16, 2023
@bedevere-app
Copy link

bedevere-app bot commented Oct 16, 2023

GH-110925 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 only security fixes label Oct 16, 2023
@vstinner
Copy link
Member

Please backport libregrtest changes to 3.11 and 3.12 branches. I just did it.

vstinner pushed a commit that referenced this pull request Oct 16, 2023
#110925)

regrtest: Prepend 'use' options in --{fast,slow}-ci (GH-110363)

This allows individual resources to be disabled without having to explicitly re-enable all others.
(cherry picked from commit b75186f)

Co-authored-by: Zachary Ware <[email protected]>
vstinner pushed a commit that referenced this pull request Oct 16, 2023
#110924)

regrtest: Prepend 'use' options in --{fast,slow}-ci (GH-110363)

This allows individual resources to be disabled without having to explicitly re-enable all others.
(cherry picked from commit b75186f)

Co-authored-by: Zachary Ware <[email protected]>
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
This allows individual resources to be disabled without having to explicitly re-enable all others.
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
This allows individual resources to be disabled without having to explicitly re-enable all others.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip issue skip news tests Tests in the Lib/test dir
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants