convert from long long to PyLong losslessly #1106
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjaminp
changed the title
|
Having to play with the different C types is painful: the availability and size of each C type depends on the platform, compiler options, etc. See bpo-17870 http://bugs.python.org/issue17870 for adding intmax_t/uintmax_t support :-) |
|
IMHO the change fixes a real bug, but it's only a function used for unit tests, so I'm not sure that it's worth it to backport it to 3.6 & 3.5. |
benjaminp
added a commit
that referenced
this pull request
Apr 13, 2017
benjaminp
added a commit
that referenced
this pull request
Apr 13, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current code can lose precision when
sizeof(long) < sizeof(long long).