gh-111019: Align expected and actual titles in test output #111020
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Align expected and actual titles in output from assert_has_calls/assert_called_with for greater readability
|
All commit authors signed the Contributor License Agreement. |
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
cjw296
added
skip issue
skip news
needs backport to 3.11
|
Yeah, this is a nice, small, quality of life improvement :-) |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Oct 18, 2023
…honGH-111020) Align expected and actual titles in output from assert_has_calls/assert_called_with for greater readability (cherry picked from commit 77dbd95) Co-authored-by: James <[email protected]>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Oct 18, 2023
…honGH-111020) Align expected and actual titles in output from assert_has_calls/assert_called_with for greater readability (cherry picked from commit 77dbd95) Co-authored-by: James <[email protected]>
|
GH-111024 is a backport of this pull request to the 3.12 branch. |
|
GH-111025 is a backport of this pull request to the 3.11 branch. |
aisk
pushed a commit
to aisk/cpython
that referenced
this pull request
Feb 11, 2024
…hon#111020) Align expected and actual titles in output from assert_has_calls/assert_called_with for greater readability
Glyphack
pushed a commit
to Glyphack/cpython
that referenced
this pull request
Sep 2, 2024
…hon#111020) Align expected and actual titles in output from assert_has_calls/assert_called_with for greater readability
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates to output of assert_called_with/assert_has_calls
# before in assert_called_with raise AssertionError(_error_message()) from cause AssertionError: expected call not found. Expected: mock('foo', 'bar') Actual: mock('foo', 'foo') # after in assert_called_with raise AssertionError(_error_message()) from cause AssertionError: expected call not found. Expected: mock('foo', 'bar') Actual: mock('foo', 'foo') ---------------------------------------------------------------------- # before in assert_has_calls raise AssertionError( AssertionError: Calls not found. Expected: [call('foo', 'bar')] Actual: [call('foo', 'foo')] # after in assert_has_calls raise AssertionError( AssertionError: Calls not found. Expected: [call('foo', 'bar')] Actual: [call('foo', 'foo')] ----------------------------------------------------------------------