Skip to content

Fix typo in sys docs #111196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 24, 2023
Merged

Fix typo in sys docs #111196

merged 2 commits into from
Oct 24, 2023

Conversation

aragilar
Copy link
Contributor

@aragilar aragilar commented Oct 23, 2023

! should be a ` (for correct rst rendering).


📚 Documentation preview 📚: https://cpython-previews--111196.org.readthedocs.build/

! should be a ` (for correct rst rendering).
@bedevere-app bedevere-app bot added awaiting review docs Documentation in the Doc dir skip news labels Oct 23, 2023
@aragilar
Copy link
Contributor Author

Looks like the tests is failing due to py:attr reference target not found: buffer. Not sure how we want to resolve this, whether we drop the directive or something else, but it looks like the docs render correctly now.

@hugovk hugovk added needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels Oct 23, 2023
Co-authored-by: Hugo van Kemenade <[email protected]>
Copy link
Member

@hugovk hugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@hugovk hugovk merged commit 6b9babf into python:main Oct 24, 2023
@miss-islington-app
Copy link

Thanks @aragilar for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 24, 2023
(cherry picked from commit 6b9babf)

Co-authored-by: James Tocknell <[email protected]>
Co-authored-by: Hugo van Kemenade <[email protected]>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 24, 2023
(cherry picked from commit 6b9babf)

Co-authored-by: James Tocknell <[email protected]>
Co-authored-by: Hugo van Kemenade <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Oct 24, 2023

GH-111248 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 only security fixes label Oct 24, 2023
@bedevere-app
Copy link

bedevere-app bot commented Oct 24, 2023

GH-111249 is a backport of this pull request to the 3.11 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.11 only security fixes label Oct 24, 2023
hugovk added a commit that referenced this pull request Oct 24, 2023
Co-authored-by: James Tocknell <[email protected]>
Co-authored-by: Hugo van Kemenade <[email protected]>
hugovk added a commit that referenced this pull request Oct 24, 2023
Co-authored-by: James Tocknell <[email protected]>
Co-authored-by: Hugo van Kemenade <[email protected]>
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip issue skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants