Skip to content

bpo-35511: Trivial docs updates for profile and resource library modules. #11124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Dec 16, 2018
Merged

bpo-35511: Trivial docs updates for profile and resource library modules. #11124

merged 7 commits into from
Dec 16, 2018

Conversation

bombs-kim
Copy link
Contributor

@bombs-kim bombs-kim commented Dec 12, 2018

Trivial corrections for the two library. Please refer to the commit message for details.

https://bugs.python.org/issue35511

> The presence of instrumented code does/doesn't deterministic profiling

, which doesn't make sense
…e time in the

interactive shell, and wondered why ru_utime, ru_stime don't add up quickly. It took me quite
some time before I figured out the interactive shell doesn't use much CPU power while it
hangs and ru_utime, ru_stime wouldn't increase much before I do some heavy CPU-bound
computation.
@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA (this might be simply due to a missing "GitHub Name" entry in your b.p.o account settings). This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for your contribution, we look forward to reviewing it!

@bombs-kim
Copy link
Contributor Author

@the-knights-who-say-ni please check CLA assignment again.

@bombs-kim bombs-kim changed the title Trivial docs updates for profile and resource library modules. [Skip Issue] Trivial docs updates for profile and resource library modules. Dec 12, 2018
Copy link
Contributor

@asvetlov asvetlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An issue on bugs.python.org and NEWS entry are required for the PR

@bedevere-bot
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@bombs-kim bombs-kim changed the title [Skip Issue] Trivial docs updates for profile and resource library modules. bpo-35511: Trivial docs updates for profile and resource library modules. Dec 16, 2018
@bombs-kim
Copy link
Contributor Author

I have made the requested changes; please review again

@bedevere-bot
Copy link

Thanks for making the requested changes!

@asvetlov: please review the changes made to this pull request.

@asvetlov
Copy link
Contributor

Thanks @bombs-kim

@bombs-kim bombs-kim deleted the docs branch December 17, 2018 02:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants