-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
gh-111490: Change what exception type we expect in test_pyexpat
#111491
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's do it. If something goes wrong, we can undo it. On the other hand, a more specific check can reveal errors that were hidden before.
|
|
@serhiy-storchaka your diff is the last one, would you please take a look?
Diff: https://github.com/python/cpython/blame/940ee962a8a1e87543fd36338228e526e7f35067/Lib/test/test_pyexpat.py#L547
test_pyexpat
has strangeassertRaises
check #111490