Skip to content

Fix test.support.Py_C_RECURSION_LIMIT to reflect Include/cpython/pystate.h more accurately #112224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 30, 2023

Conversation

brettcannon
Copy link
Member

No description provided.

@vstinner
Copy link
Member

The _testcapi extension should always be available when running the Python test suite. I suppose that the ImportError code path is for Python implementation others than CPython, no?

@brettcannon
Copy link
Member Author

The _testcapi extension should always be available when running the Python test suite. I suppose that the ImportError code path is for Python implementation others than CPython, no?

I have no idea since I didn't add that code.

@vstinner
Copy link
Member

@markshannon: Do you have an opinion on this change?

@brettcannon: If you want to sync the Python support code with the C header file, you may also add the Py_DEBUG case. (But I'm asking if it's worth it, since you can expect the _testcapi extension to be available in CPython.)

@brettcannon
Copy link
Member Author

If we end up not bothering with this PR then I will update the comment to drop the pystate.h comment as it's misleading if it doesn't have to be kept in sync.

@brettcannon
Copy link
Member Author

Switching to just clarifying the comment so it implies it doesn't need to be kept in sync with the header file.

@brettcannon brettcannon merged commit 6d5e0dc into python:main Nov 30, 2023
@brettcannon brettcannon deleted the wasi-_get_c_recursion_limit branch November 30, 2023 21:38
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
…t where a value came from but that it doesn't need to stay in sync (python#112224)
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
…t where a value came from but that it doesn't need to stay in sync (python#112224)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants