Fix "Py_TPFLAGS_MANAGED_WEAKREF is set in tp_flags" #112237
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix a small error in the documentation: `Py_TPFLAGS_MANAGED_WEAKREF` is set in the `tp_flags` field rather than the `tp_dict` field
bedevere-app
bot
added
awaiting review
docs
|
@Eclips4 Sorry for bumping it after you approved it. I spotted a second error in the same section that seemed worth fixing at the same time. |
da-woods
commented
Nov 18, 2023
arhadthedev
added
needs backport to 3.11
|
@markshannon Pinging you because I think both changes in this PR touch lines that you added. This is a fairly trivial documentation fix I think. |
kumaraditya303
approved these changes
Jul 3, 2024
|
Thanks @da-woods for the PR, and @kumaraditya303 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jul 3, 2024
…12237) (cherry picked from commit 4232976) Co-authored-by: da-woods <[email protected]>
|
GH-121309 is a backport of this pull request to the 3.13 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jul 3, 2024
…12237) (cherry picked from commit 4232976) Co-authored-by: da-woods <[email protected]>
|
GH-121310 is a backport of this pull request to the 3.12 branch. |
kumaraditya303
pushed a commit
that referenced
this pull request
Jul 3, 2024
…112237) (#121310) docs: Fix "Py_TPFLAGS_MANAGED_WEAKREF is set in tp_flags" (GH-112237) (cherry picked from commit 4232976) Co-authored-by: da-woods <[email protected]>
kumaraditya303
pushed a commit
that referenced
this pull request
Jul 3, 2024
…112237) (#121309) docs: Fix "Py_TPFLAGS_MANAGED_WEAKREF is set in tp_flags" (GH-112237) (cherry picked from commit 4232976) Co-authored-by: da-woods <[email protected]>
noahbkim
pushed a commit
to hudson-trading/cpython
that referenced
this pull request
Jul 11, 2024
estyxx
pushed a commit
to estyxx/cpython
that referenced
this pull request
Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a small error in the documentation:
Py_TPFLAGS_MANAGED_WEAKREFis set in thetp_flagsfield rather than thetp_dictfield📚 Documentation preview 📚: https://cpython-previews--112237.org.readthedocs.build/